Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Engine Standard should always use the uberjar #21634

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

loicmathieu
Copy link
Contributor

Fixes #21564

@loicmathieu
Copy link
Contributor Author

/cc @mkouba

@loicmathieu loicmathieu requested a review from mkouba November 23, 2021 09:27
@asodja
Copy link
Contributor

asodja commented Nov 23, 2021

Sorry if this if it is somehow unrelated, but I saw this change:
I was actually using AppEngine Standard Java 11 with a fast-jar. I used gcloud to deploy artifacts and I had to also specify a custom entry point.

But it might be true that if you use some maven-plugin for deploy it won't work.

@loicmathieu
Copy link
Contributor Author

@asodja yes, this is not the only way to do it but it's the simplier way that works in all cases.

Feel free to enhance the guide with fast-jar (aka default packaging) and a default entry point.

@loicmathieu
Copy link
Contributor Author

@mkouba did you check the wording or should I ask someone to do it ?
I don't know your level of english but mine deserve someone to check it ;)

@loicmathieu
Copy link
Contributor Author

@geoand I applied your suggestions

@geoand geoand merged commit 1a91a96 into quarkusio:main Nov 23, 2021
@gsmet gsmet modified the milestones: 2.6 - main, 2.5.1.Final Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Cloud guide - build via Maven plugin should use uber-jar packaging
5 participants