Only warn about loggable messages #21473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/devtools
gastaldi
approved these changes
Nov 15, 2021
mkouba
reviewed
Nov 16, 2021
...jects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java
Outdated
Show resolved
Hide resolved
mamadaliev
approved these changes
Nov 16, 2021
If messages are dropped that would have been loggable then we display the warning, otherwise we ignore it as the end result is the same.
gastaldi
force-pushed
the
log-messages
branch
from
41e8121 to
14aa776
Compare
|
@stuartwdouglas hope you don't mind, I rebased your branch and included |
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Nov 24, 2021
See quarkusio#21473 (comment) (cherry picked from commit 14aa776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If messages are dropped that would have been loggable then we display
the warning, otherwise we ignore it as the end result is the same.