Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kotlin serialization to resteasy reactive #21318

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add support for kotlin serialization to resteasy reactive #21318

merged 1 commit into from
Dec 16, 2021

Conversation

evanchooly
Copy link
Member

No description provided.

@evanchooly evanchooly marked this pull request as draft November 9, 2021 16:44
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/rest labels Nov 9, 2021
@geoand
Copy link
Contributor

geoand commented Dec 12, 2021

This is going to need a rebase

Copy link
Contributor

@rgmz rgmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question from an interested party.

Also, would it be prudent to write a serializer for kotlinx-serialization JsonObject to Vert.x JsonObject?
Kotlin/kotlinx.serialization#296

@evanchooly
Copy link
Member Author

this is ready to give a serious look at @geoand . There are likely some cleanups to do here and there and no doubt some tweaking with the reactive bits but it seems to be sending and receiving properly using kotlin serialization now.

@geoand
Copy link
Contributor

geoand commented Dec 13, 2021

Great! I'll have a look tomorrow

@evanchooly evanchooly marked this pull request as ready for review December 13, 2021 18:30
@geoand geoand added area/kotlin release/noteworthy-feature and removed area/documentation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Dec 14, 2021
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Dec 14, 2021
@evanchooly
Copy link
Member Author

I added some config tests. I did it as a 3rd module simply because running the kotlin-serialization plugin in the deployment module seemed to confuse the integration tests.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some dependency issue, looks good!

Let's get those fixed and then merge this

@evanchooly evanchooly requested a review from geoand December 16, 2021 16:16
@evanchooly evanchooly merged commit e1a487b into quarkusio:main Dec 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 16, 2021
if (o is String) { // YUK: done in order to avoid adding extra quotes...
stream.write(o.toByteArray())
} else {
val encodeToString = json.encodeToString(json.serializersModule.serializer(genericType), o)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you have used encodeToStream here also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I miss one? I'll double check when I'm back at my computer.

@evanchooly evanchooly deleted the kotSerial branch December 17, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kotlin area/rest release/noteworthy-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants