Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vert.x 4.2.1 and related projects #21195

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

cescoffier
Copy link
Member

Dependencies:

  • Update to Vert.x 4.2.1
  • Update to Stork 1.0.0.Beta1
  • Update to Vert.x Mutiny Bindings 2.15.0
  • Update to Quarkus HTTP 4.1.4

Core and HTTP:

  • New cookie-related methods
  • Relocation of the CACHE_DIR_BASE_PROP_NAME constant
  • Update native image configuration for Vert.x

Data Source:

  • New preparedQuery method in Pool

Redis:

  • Signature changes of the lpop, psync and rpop command
  • The workaround done in Quarkus does not break compatibility

Amazon Lambda:

  • Relocation of the CACHE_DIR_BASE_PROP_NAME constant

@geoand
Copy link
Contributor

geoand commented Nov 4, 2021

Seems like the PR needs a rebase :)

Dependencies:

- Update to Vert.x 4.2.1
- Update to Stork 1.0.0.Beta1
- Update to Vert.x Mutiny Bindings 2.15.0
- Update to Quarkus HTTP 4.1.4

Core and HTTP:

- New cookie-related methods
- Relocation of the CACHE_DIR_BASE_PROP_NAME constant
- Update native image configuration for Vert.x

Data Source:

- New preparedQuery method in Pool

Redis:

- Signature changes of the lpop, psync and rpop command
- The workaround done in Quarkus does not break compatibility

Amazon Lambda:

- Relocation of the CACHE_DIR_BASE_PROP_NAME constant
@cescoffier cescoffier force-pushed the integration-of-vertx-4.2.1 branch from c6e525d to 6e7b093 Compare November 4, 2021 14:32
@cescoffier
Copy link
Member Author

@geoand yep... Let's see what's the CI is going to say...

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 6e7b093

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Data4 Build Failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.devmode.ArcEndpointTest.testBeans line 31 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.CompileProblemTest.test line 24 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.LiveReloadArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.ParentFirstArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 30 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testAddFilter line 61 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testAddBean line 48 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestFailingBeforeAllTestCase.testBrokenBeforeAllHandling line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 45 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.metaannotations.MetaAnnotationsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.params.TestParameterizedTestCase.testParameterizedTests line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <4> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.devmode.ArcEndpointTest.testBeans line 31 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.devmode.CompileProblemTest.test line 24 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.devmode.LiveReloadArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.devmode.ParentFirstArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 30 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testAddFilter line 61 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testAddBean line 48 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestFailingBeforeAllTestCase.testBrokenBeforeAllHandling line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 45 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.metaannotations.MetaAnnotationsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.params.TestParameterizedTestCase.testParameterizedTests line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <4> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ Native Tests - Data4 #

- Failing: integration-tests/redis-client 

📦 integration-tests/redis-client

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-redis-client: Failed to build quarkus application


⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator 

📦 integration-tests/hibernate-validator

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

@cescoffier
Copy link
Member Author

@stuartwdouglas I got some odd failures in some DevMode tests. The port seems wrong. It passes sometimes and sometimes it just got a wrong port.
I've tried to inject the URL and get the port, but even with that, it can get the wrong one.
Do you know where I should look?

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 86d0b27

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.devmode.ArcEndpointTest.testBeans line 31 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.CompileProblemTest.test line 24 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.LiveReloadArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.devmode.ParentFirstArtifactTest.test line 25 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 30 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testAddFilter line 61 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testAddBean line 48 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)

io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestFailingBeforeAllTestCase.testBrokenBeforeAllHandling line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 45 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.metaannotations.MetaAnnotationsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.params.TestParameterizedTestCase.testParameterizedTests line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <4> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorBodyHandlerTest.testChangeHttpRoute line 31 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorTest.testChangeHttpRoute line 24 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorTest.testSetEmptyValue line 48 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 30 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testAddFilter line 61 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testAddBean line 48 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 26 - More details - Source on GitHub

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)

Also clear the config after augmentation, which could cause issues when
attempting to inject URL's into dev mode tests, as they could see a left
over 8081 URL instead of 8080.
@quarkus-bot quarkus-bot bot added the area/core label Nov 5, 2021
@stuartwdouglas
Copy link
Member

@cescoffier I think I have fixed it, lets see how this commit goes.

@cescoffier
Copy link
Member Author

Awesome thanks @stuartwdouglas !

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@geoand geoand merged commit 0bfd2fb into quarkusio:main Nov 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 5, 2021
@cescoffier cescoffier deleted the integration-of-vertx-4.2.1 branch November 5, 2021 06:39
@Sanne
Copy link
Member

Sanne commented Nov 5, 2021

Nice! HR upgrade coming in a moment

@tsegismont
Copy link
Contributor

tsegismont commented Nov 5, 2021

Nice! HR upgrade coming in a moment

Same for MSSQL TLS options

@Sanne
Copy link
Member

Sanne commented Nov 5, 2021

Related: - #21220

@Sanne
Copy link
Member

Sanne commented Nov 5, 2021

@cescoffier N.B. that Vert.x 4.2.1 is using Netty 4.1.69

shouldn't we align? I need a feature in the later Netty :)

@Sanne
Copy link
Member

Sanne commented Nov 5, 2021

nevermind, the Netty version matches already - sorry got confused with branches while testing.

@cescoffier
Copy link
Member Author

We are working on integrating 4.1.70, but we need to be sure Vert.x works with it. I will get the response to that question next week.

tsegismont added a commit to tsegismont/quarkus that referenced this pull request Nov 5, 2021
With the latest Vert.x upgrade (see quarkusio#21195) it is now possible to support SSL/TLS.

The reactive mssql client extension will now enable native SSL support by default.

Also, missing sections have been added in the doc:

- client details
- client specific config
@Sanne
Copy link
Member

Sanne commented Nov 5, 2021

We are working on integrating 4.1.70, but we need to be sure Vert.x works with it. I will get the response to that question next week.

sorry I got confused: I was needing 4.1.69 - it's there already so all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants