-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vert.x 4.2.1 and related projects #21195
Conversation
Seems like the PR needs a rebase :) |
Dependencies: - Update to Vert.x 4.2.1 - Update to Stork 1.0.0.Beta1 - Update to Vert.x Mutiny Bindings 2.15.0 - Update to Quarkus HTTP 4.1.4 Core and HTTP: - New cookie-related methods - Relocation of the CACHE_DIR_BASE_PROP_NAME constant - Update native image configuration for Vert.x Data Source: - New preparedQuery method in Pool Redis: - Signature changes of the lpop, psync and rpop command - The workaround done in Quarkus does not break compatibility Amazon Lambda: - Relocation of the CACHE_DIR_BASE_PROP_NAME constant
c6e525d
to
6e7b093
Compare
@geoand yep... Let's see what's the CI is going to say... |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6e7b093
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more 📦 extensions/vertx-http/deployment✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more 📦 extensions/vertx-http/deployment✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
⚙️ Native Tests - Data4 #- Failing: integration-tests/redis-client
📦 integration-tests/redis-client✖ ⚙️ Native Tests - Windows - hibernate-validator #- Failing: integration-tests/hibernate-validator
📦 integration-tests/hibernate-validator✖ |
@stuartwdouglas I got some odd failures in some DevMode tests. The |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 86d0b27
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more 📦 extensions/vertx-http/deployment✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 297 more 📦 extensions/vertx-http/deployment✖
✖
✖
✖
✖
✖
✖
✖
|
Also clear the config after augmentation, which could cause issues when attempting to inject URL's into dev mode tests, as they could see a left over 8081 URL instead of 8080.
@cescoffier I think I have fixed it, lets see how this commit goes. |
Awesome thanks @stuartwdouglas ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Nice! HR upgrade coming in a moment |
Same for MSSQL TLS options |
Related: - #21220 |
@cescoffier N.B. that Vert.x 4.2.1 is using Netty shouldn't we align? I need a feature in the later Netty :) |
nevermind, the Netty version matches already - sorry got confused with branches while testing. |
We are working on integrating 4.1.70, but we need to be sure Vert.x works with it. I will get the response to that question next week. |
With the latest Vert.x upgrade (see quarkusio#21195) it is now possible to support SSL/TLS. The reactive mssql client extension will now enable native SSL support by default. Also, missing sections have been added in the doc: - client details - client specific config
sorry I got confused: I was needing 4.1.69 - it's there already so all good 👍 |
Dependencies:
Core and HTTP:
Data Source:
Redis:
Amazon Lambda: