Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple quarkus-spring-web from RESTEasy Classic #21082

Closed
wants to merge 1 commit into from
Closed

Decouple quarkus-spring-web from RESTEasy Classic #21082

wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 29, 2021 •
edited
Loading

This is prerequisite work for being able to run
Spring Web endpoints on RESTEasy Reactive in addition
to RESTEasy Classic (work which I'll do once this is in).

The decoupling is achieved by using conditional
dependencies and moving RESTEasy specific code
to a new extension.

This is a breaking change because users now how to include quarkus-resteasy-jackson on their own

@geoand geoand requested a review from aloubyansky October 29, 2021 09:09
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/spring Issues relating to the Spring integration labels Oct 29, 2021
@geoand geoand removed the area/dependencies Pull requests that update a dependency file label Oct 29, 2021
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Oct 29, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d8b6dc5

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Verify extension dependencies ⚠️ Check → Logs Raw logs

@geoand
Decouple quarkus-spring-web from RESTEasy Classic
24eda12 
This is prerequisite work for being able to run
Spring Web endpoints on RESTEasy Reactive in addition
to RESTEasy Classic.

The decoupling is achieved by using conditional
dependencies and moving RESTEasy specific code
to a new extension
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Oct 29, 2021
@geoand
Copy link
Contributor Author

geoand commented Oct 29, 2021

I'll close this because I am already working on the next PR, so they can go in together

@geoand geoand closed this Oct 29, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 29, 2021
@geoand geoand mentioned this pull request Oct 29, 2021
Merged
@geoand
Copy link
Contributor Author

geoand commented Oct 29, 2021 •
edited
Loading

Superseded by #21089

@geoand geoand deleted the spring-web-rr branch October 29, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/spring Issues relating to the Spring integration release/breaking-change triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geoand