Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - prefix iteration metadata in a loop #21000

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Qute - prefix iteration metadata in a loop #21000

merged 1 commit into from
Nov 4, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 26, 2021

@mkouba mkouba added this to the 2.5 - main milestone Oct 26, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Oct 26, 2021

This is a breaking change. We're going to update the migration guide when/if the PR is merged.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 26, 2021

NOTE: For type-safe templates with @CheckedTemplate#requireTypeSafeExpressions=true (default) an invalid usage of iteration metadata keys results in a build time error with a relevant message. However, we can't reliably detect an invalid usage in other cases (here a standard error message is used).

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4435e7b

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/devmode

📦 integration-tests/devmode

✖ io.quarkus.test.devconsole.DevConsoleHibernateOrmSmokeTest.testPages - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/devmode

📦 integration-tests/devmode

✖ io.quarkus.test.devconsole.DevConsoleHibernateOrmSmokeTest.testPages - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/devmode integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/devmode

✖ io.quarkus.test.devconsole.DevConsoleHibernateOrmSmokeTest.testPages - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <3> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@mkouba mkouba requested review from FroMage and gsmet October 27, 2021 10:32
@mkouba mkouba force-pushed the issue-20671-next branch 2 times, most recently from 41f5c48 to 358db92 Compare October 27, 2021 10:50
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 358db92

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✖ Native Tests - Messaging2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <4> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/vault-agroal

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@mkouba mkouba requested a review from gastaldi November 1, 2021 15:36
gastaldi
gastaldi approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba
Copy link
Contributor Author

mkouba commented Nov 2, 2021

CC @FroMage @gsmet

@mkouba mkouba force-pushed the issue-20671-next branch 2 times, most recently from 73480b3 to c7cb26b Compare November 4, 2021 09:44
@mkouba
Qute - prefix iteration metadata in a loop
0c400f5 
- the prefix is configurable (globally)
- also added "isFirst" and "isLast" properties for convenience
- resolves quarkusio#20671
@mkouba
Copy link
Contributor Author

mkouba commented Nov 4, 2021

The Native Tests - Windows - hibernate-validator failure is not related:

2021-11-04T11:44:17.3729938Z LINK : fatal error LNK1171: unable to load mspdbcore.dll (error code: 1455)
2021-11-04T11:44:17.3731966Z 	at com.oracle.svm.hosted.image.NativeImageViaCC.handleLinkerFailure(NativeImageViaCC.java:502)
2021-11-04T11:44:17.3738330Z 	at com.oracle.svm.hosted.image.NativeImageViaCC.write(NativeImageViaCC.java:449)
2021-11-04T11:44:17.3740901Z 	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:657)
2021-11-04T11:44:17.3743463Z 	at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:488)
2021-11-04T11:44:17.3746581Z 	at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:403)
2021-11-04T11:44:17.3756229Z 	at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:569)
2021-11-04T11:44:17.3759036Z 	at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:122)
2021-11-04T11:44:17.3842819Z 	at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:599)

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2021

Failing Jobs - Building 0c400f5

Status Name Step Failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator Build Failures Logs Raw logs

Failures

⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator

📦 integration-tests/hibernate-validator

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

@mkouba
Copy link
Contributor Author

mkouba commented Nov 4, 2021

I'm going to merge this one. We can address potential problems later...

@mkouba mkouba merged commit 4940f06 into quarkusio:main Nov 4, 2021
@kwakiutlCS kwakiutlCS mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@FroMage FroMage Awaiting requested review from FroMage

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/grpc gRPC area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE area/qute The template engine area/reactive-messaging area/rest area/scheduler area/smallrye area/vertx release/breaking-change
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute: prefix loop metadata
2 participants
@mkouba @gastaldi