Ensure that a large response does not cause OOM in RESTEasy Classic #20907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea of this change is to make the allocation of buffers only happen when the previous write has been completed, as opposed to the previous behavior where all the buffers where allocated upfront and could never be deallocated if one of the writes caused an error Fixes: quarkusio#20822
|
Just as a note, I tested this with the code of the original issue and with other scenarios as well and it worked flawlessly |
|
@stuartwdouglas can you take a look at this one? Thanks |
stuartwdouglas
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this change is to make the allocation of buffers only happen
when the previous write has been completed, as opposed to the previous
behavior where all the buffers where allocated upfront and could never
be deallocated if one of the writes caused an error
Fixes: #20822