Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle integration test leveraging annotation processor #20816

Merged

Conversation

glefloch
Copy link
Member

This adds gradle integration tests leveraging annotation processor for both normal project and multi-module project.

@glefloch glefloch requested a review from aloubyansky October 17, 2021 18:39
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Oct 17, 2021
@aloubyansky
Copy link
Member

That'll be good to have. However there is also a mapstruct plugin, iirc. That would be yet another use-case.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 17, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cc27517

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AnnotationProcessorMultiModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AnnotationProcessorMultiModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@glefloch glefloch force-pushed the fix/add-annotation-processor-test branch from cc27517 to d197dd1 Compare October 18, 2021 12:34
implementation 'io.quarkus:quarkus-resteasy-jackson'
implementation 'org.mapstruct:mapstruct:1.4.2.Final'

annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glefloch could you please move these versions to the properties file? Ideally, it'd be great if we had them in the quarkus build parent or something, so we can update them all in one place instead of digging through the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, there was no other mapstruct reference. I put the version in the pom.xml of the integration-test/gradle module.

@glefloch glefloch force-pushed the fix/add-annotation-processor-test branch 2 times, most recently from f4b376b to a630edc Compare October 18, 2021 17:13
dependencies {
implementation "org.mapstruct:mapstruct:${mapstructVersion}"

annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final'
annotationProcessor "org.mapstruct:mapstruct-processor:${mapstructVersion}"


implementation 'io.quarkus:quarkus-resteasy'
implementation 'io.quarkus:quarkus-resteasy-jackson'
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
implementation "org.mapstruct:mapstruct:${mapstructVersion}"


implementation 'io.quarkus:quarkus-resteasy'
implementation 'io.quarkus:quarkus-resteasy-jackson'
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
implementation "org.mapstruct:mapstruct:${mapstructVersion}"


implementation 'io.quarkus:quarkus-resteasy'
implementation 'io.quarkus:quarkus-resteasy-jackson'
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementation 'org.mapstruct:mapstruct:1.4.2.Final'
implementation "org.mapstruct:mapstruct:${mapstructVersion}"

@glefloch glefloch force-pushed the fix/add-annotation-processor-test branch from a630edc to c0dc456 Compare October 18, 2021 18:56
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c0dc456

Status Name Step Failures Logs Raw logs
Native Tests - Misc4 Set up JDK 11 ⚠️ Check → Logs Raw logs

@aloubyansky aloubyansky merged commit 91b0666 into quarkusio:main Oct 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants