-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle integration test leveraging annotation processor #20816
Add gradle integration test leveraging annotation processor #20816
Conversation
That'll be good to have. However there is also a mapstruct plugin, iirc. That would be yet another use-case. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building cc27517
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
|
cc27517
to
d197dd1
Compare
implementation 'io.quarkus:quarkus-resteasy-jackson' | ||
implementation 'org.mapstruct:mapstruct:1.4.2.Final' | ||
|
||
annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glefloch could you please move these versions to the properties file? Ideally, it'd be great if we had them in the quarkus build parent or something, so we can update them all in one place instead of digging through the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, there was no other mapstruct reference. I put the version in the pom.xml of the integration-test/gradle
module.
f4b376b
to
a630edc
Compare
dependencies { | ||
implementation "org.mapstruct:mapstruct:${mapstructVersion}" | ||
|
||
annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotationProcessor 'org.mapstruct:mapstruct-processor:1.4.2.Final' | |
annotationProcessor "org.mapstruct:mapstruct-processor:${mapstructVersion}" |
|
||
implementation 'io.quarkus:quarkus-resteasy' | ||
implementation 'io.quarkus:quarkus-resteasy-jackson' | ||
implementation 'org.mapstruct:mapstruct:1.4.2.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation 'org.mapstruct:mapstruct:1.4.2.Final' | |
implementation "org.mapstruct:mapstruct:${mapstructVersion}" |
|
||
implementation 'io.quarkus:quarkus-resteasy' | ||
implementation 'io.quarkus:quarkus-resteasy-jackson' | ||
implementation 'org.mapstruct:mapstruct:1.4.2.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation 'org.mapstruct:mapstruct:1.4.2.Final' | |
implementation "org.mapstruct:mapstruct:${mapstructVersion}" |
|
||
implementation 'io.quarkus:quarkus-resteasy' | ||
implementation 'io.quarkus:quarkus-resteasy-jackson' | ||
implementation 'org.mapstruct:mapstruct:1.4.2.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation 'org.mapstruct:mapstruct:1.4.2.Final' | |
implementation "org.mapstruct:mapstruct:${mapstructVersion}" |
a630edc
to
c0dc456
Compare
This adds gradle integration tests leveraging annotation processor for both normal project and multi-module project.