Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Clean the Gradle temp directory #20791

Merged
merged 1 commit into from
Oct 18, 2021
Merged

CI - Clean the Gradle temp directory #20791

merged 1 commit into from
Oct 18, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 15, 2021

Hopefully, this will fix the errors we have when trying to upload
artifacts.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Oct 15, 2021
@gsmet gsmet requested a review from famod October 15, 2021 09:40
@famod
Copy link
Member

famod commented Oct 15, 2021

How does gradlew --stop behave if no gradle module was executed (hence no daemon was started?)? If it returns with > 0 this step will probaly fail.

Couldn't we prevent the daemon from being started in the first place?
Btw, we did enable the daemon on purpose for Gradle ITs, but those are run in a sperate job.

@gsmet
Copy link
Member Author

gsmet commented Oct 15, 2021

It just prints No Gradle daemons are running. and exits with success so we should be fine.

As for if it's necessary, I just want to try if it improves things.

famod
famod approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!

@famod
Copy link
Member

famod commented Oct 15, 2021

If you really want to provoke it here, then you'll probably have to remove the if: failure().

@gsmet
CI - Clean the Gradle temp directory
b27c227 
Hopefully, this will fix the errors we have when trying to upload
artifacts.
@gsmet gsmet force-pushed the clean-gradle-temp-files branch from de9e484 to b27c227 Compare October 15, 2021 11:09
@gsmet gsmet merged commit 93f3547 into quarkusio:main Oct 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 18, 2021
@aloubyansky aloubyansky modified the milestones: 2.5 - main, 2.4.0.Final Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
2.4.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @famod @aloubyansky