Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract test-only dependencies from the bootstrap-bom #20667

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

aloubyansky
Copy link
Member

Given that the quarkus-bootstrap-bom gets imported into the quarkus-bom, it'd be better to keep dependency constraints that are used only for testing of the bootstrap modules out of the quarkus-bootstrap-bom.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Oct 11, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2021

Failing Jobs - Building d2e0247

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloubyansky aloubyansky merged commit 5f54ab9 into quarkusio:main Oct 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 12, 2021
@aloubyansky aloubyansky modified the milestones: 2.5 - main, 2.4.0.Final Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants