Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jandex and jandex-maven-plugin versions #20616

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Update jandex and jandex-maven-plugin versions #20616

merged 1 commit into from
Oct 8, 2021

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Oct 8, 2021

No description provided.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 8, 2021
@nastra nastra mentioned this pull request Oct 8, 2021
Merged
@aloubyansky aloubyansky requested a review from Ladicek October 8, 2021 09:09
Ladicek
Ladicek approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to do this, thanks for being faster :-)

Ladicek
Ladicek requested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no, I'm wrong, you also need to update bom/application/pom.xml.

@nastra nastra force-pushed the update-jandex-and-jandex-maven-plugin branch from e36cb3e to 53b8439 Compare October 8, 2021 11:57
@nastra
Copy link
Contributor Author

nastra commented Oct 8, 2021

@Ladicek done, not sure how I missed that. Thanks for the review

@nastra nastra requested a review from Ladicek October 8, 2021 11:59
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 8, 2021
@aloubyansky aloubyansky merged commit 69a9751 into quarkusio:main Oct 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 8, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 8, 2021
@nastra nastra deleted the update-jandex-and-jandex-maven-plugin branch October 11, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@nastra @Ladicek @gastaldi @aloubyansky