Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmallRye Health codestart #20584

Merged
merged 1 commit into from
Oct 7, 2021
Merged

SmallRye Health codestart #20584

merged 1 commit into from
Oct 7, 2021

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Oct 7, 2021 •
edited
Loading

Fixes #20553

@jmartisk jmartisk requested a review from ia3andy October 7, 2021 10:31
@jmartisk
Copy link
Contributor Author

jmartisk commented Oct 7, 2021

cc @xstefank

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/health area/smallrye labels Oct 7, 2021
xstefank
xstefank approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the content perspective. Not familiar with codestarts part.

ia3andy
ia3andy reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmartisk 👌

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2021

Failing Jobs - Building 5d97ed3

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@ia3andy
Copy link
Contributor

ia3andy commented Oct 7, 2021 •
edited
Loading

@geoand any idea of what's going on with oidc?

Should I restart the CI?

@geoand
Copy link
Contributor

geoand commented Oct 7, 2021

Not a clue. @sberyozkin ?

@ia3andy
Copy link
Contributor

ia3andy commented Oct 7, 2021

I think it's safe to merge this..

@ia3andy ia3andy merged commit 8f312f5 into quarkusio:main Oct 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 7, 2021
@jmartisk jmartisk deleted the health-codestart branch October 8, 2021 06:06
@ia3andy
Copy link
Contributor

ia3andy commented Oct 12, 2021

Hey @jmartisk

Your new codestart is available on 2.4 CR1 https://code.quarkus.io/?a=some-healthy-app&e=smallrye-health&S=io.quarkus.platform%3A2.4

I created an email template for new extension codestart:
https://hackmd.io/@ZJbzQRBpQ9OZjrz_J-KZhA/rkhCG3MBY

Would you send it to quarkus-dev?

Cheers,

@jmartisk
Copy link
Contributor Author

done :)

@gsmet gsmet modified the milestones: 2.4.0.CR1, 2.3.1.Final Oct 18, 2021
@rsvoboda rsvoboda added the kind/enhancement New feature or request label Nov 22, 2021
@gsmet gsmet modified the milestones: 2.3.1.Final, 2.2.4.Final Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/health area/smallrye kind/enhancement New feature or request
Projects
None yet
Milestone
2.2.4.Final
Development

Successfully merging this pull request may close these issues.

SmallRye Health codestart (in java and kotlin)
6 participants
@jmartisk @ia3andy @geoand @xstefank @rsvoboda @gsmet