Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gradle plugin artifact from dev mode launcher classpath #20574

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Oct 6, 2021

This branch removes the plugin dependency lookup. also, it fixes an error where the plugin was not as a buildSrc dependency.

close #20531

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Oct 6, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glefloch glefloch merged commit dd7c05a into quarkusio:main Oct 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 6, 2021
@glefloch glefloch deleted the fix/20531 branch October 6, 2021 20:52
@gsmet gsmet modified the milestones: 2.4.0.CR1, 2.3.1.Final Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusDev fails to start when using a Gradle convention plugin
4 participants