Prefer workspace paths only for artifacts that are not extensions or their dependencies #20572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their dependencies
quarkus-bot
bot
added
the
area/devtools
| if (collectReloadableModules) { | ||
| appBuilder.addReloadableWorkspaceModule(new GACT(artifact.getGroupId(), artifact.getArtifactId())); | ||
| } | ||
| } | ||
| if (extDep != null) { |
There was a problem hiding this comment.
What does bringing if (extDep!=null)... under if(add) do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GRPC dev mode tests in the deployment module.
The issue was caused by the bootstrap refactoring PR which preferred local workspace paths (classes dirs) to the JARs as the resolved artifact paths in dev mode and tests.
This PR makes sure extension artifacts and their dependencies are resolved as JARs, like before.