Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling in Reactive Messaging HTTP #20557

Conversation

michalszynkiewicz
Copy link
Member

fixes #20543

if (guard.prepareToEmit()) {
if (emitter == null) {
onUnexpectedError(event, null,
"No consumer subscribed for messages sent to Reactive Messaging HTTP endpoint");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would indicate the channel name if you have it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't ATM, I'll see if I can propagate it here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not easy, adding path would be easier, and should be a good enough indicator of the place, WDYT?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@michalszynkiewicz michalszynkiewicz force-pushed the reactive-messaging-http-better-error branch from b3521d0 to e29bcde Compare October 6, 2021 12:00
@michalszynkiewicz michalszynkiewicz merged commit 3271bbd into quarkusio:main Oct 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem wiring up a SSE endpoint with an internal channel with the reactive messaging HTTP connector
2 participants