Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI - qute - improve the "render preview" page #20548

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 6, 2021

  • use codemirror editor for test data
  • prefill the test data for type-safe templates
  • show the source of the template

@mkouba mkouba requested a review from phillip-kruger October 6, 2021 06:21
@quarkus-bot quarkus-bot bot added area/qute The template engine area/vertx labels Oct 6, 2021
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 6, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 6, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7abdf7d

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/qute/deployment 
! Skipped: docs extensions/mailer/deployment extensions/resteasy-classic/resteasy-qute/deployment and 4 more

📦 extensions/qute/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-qute-deployment: There was a timeout in the fork


⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/qute/deployment 
! Skipped: docs extensions/mailer/deployment extensions/resteasy-classic/resteasy-qute/deployment and 4 more

📦 extensions/qute/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-qute-deployment: There was a timeout in the fork


⚙️ JVM Tests - JDK 17 #

- Failing: extensions/qute/deployment 
! Skipped: docs extensions/mailer/deployment extensions/resteasy-classic/resteasy-qute/deployment and 4 more

📦 extensions/qute/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-qute-deployment: There was a timeout in the fork

- use codemirror editor for test data
- prefill the test data for type-safe templates
- show the source of the template
@mkouba mkouba force-pushed the qute-devui-improvements branch from 7abdf7d to e99bf48 Compare October 6, 2021 11:46
@mkouba mkouba merged commit 623a957 into quarkusio:main Oct 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 6, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants