Honor explicit container-build=false when container-runtime is set #20517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm +0 on this. @gastaldi WDYT? |
|
@geoand I think it makes sense, but I am not sure if this change will break existing behavior, may be worth adding also an entry to the changelog wiki |
|
This is a breaking change. I would prefer container build to be changed to an Optional, and if it is set explicitly then honor it, otherwise keep the current behavior. |
Makes -Dquarkus.native.container-runtime=docker not imply -Dquarkus.native.container-build=true when the latter is explicitly set to false. Additionally makes isContainerBuild checks consistent. I.e. if -Dquarkus.native.container-runtime=podman -Dquarkus.native.container-build=false are passed as parameters Quarkus will not use a builder image. Closes: quarkusio#20258
That makes more sense, indeed! I updated the PR to implement this. |
zakkak
changed the title
stuartwdouglas
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes -Dquarkus.native.container-runtime=docker not imply
-Dquarkus.native.container-build=true when the latter is explicitly set
to false. Additionally makes isContainerBuild checks consistent.
I.e. if -Dquarkus.native.container-runtime=podman
-Dquarkus.native.container-build=false are passed as parameters Quarkus
will not use a builder image.
Closes: #20258