Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute type-safe validation fix #20515

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Qute type-safe validation fix #20515

merged 1 commit into from
Oct 4, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 4, 2021

- also include all methods from the interfaces extended by other
interfaces (not only from those implemented directly by any class in the
hierarchy)
- resolves quarkusio#20512
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 4, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Oct 4, 2021

CC @wjglerum

@wjglerum
Copy link
Contributor

wjglerum commented Oct 4, 2021

CC @wjglerum

Hi @mkouba, thanks for the quick fix! I was messing around with this last night, but couldn't get it fully working. Going through the hierarchy recursively seems the best approach indeed 👍

@geoand
Copy link
Contributor

geoand commented Oct 4, 2021

@mkouba any reason this is marked for backport to 2.2 only?

@mkouba
Copy link
Contributor Author

mkouba commented Oct 4, 2021

@mkouba any reason this is marked for backport to 2.2 only?

No reason, I thought that it will be backported into 2.3 automatically ;-)

@geoand
Copy link
Contributor

geoand commented Oct 4, 2021

There is no such thing as an automatic backport once a CR of a release it out :)

@mkouba
Copy link
Contributor Author

mkouba commented Oct 4, 2021

There is no such thing as an automatic backport once a CR of a release it out :)

Ok, will do next time. My bad consideration was that I should mark the furthest backport version only... Sorry about that.

@geoand
Copy link
Contributor

geoand commented Oct 4, 2021

No problem at all!

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit 597f550 into quarkusio:main Oct 4, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 4, 2021
@wjglerum
Copy link
Contributor

Are there any plans to backport this to a 2.2.x or 2.3.x release? Or will it be just released with the upcoming 2.4.x release?

I'm asking as it currently blocks us from upgrading from 2.1.x with strict rendering enabled for Qute.

@geoand
Copy link
Contributor

geoand commented Oct 14, 2021

It's already part 2.4.0.CR1. We will likely do a 2.3.1.Final as well soon and as can be seen in the labels of the issue, it is marked for inclusion.

@wjglerum
Copy link
Contributor

Thanks for the update @geoand a 2.3.1.Final would be nice, in the meantime I'll play around with the 2.4.0.CR1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute fails to find methods from parent interface when using multilevel inheritance
5 participants