Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate config property injection points #205

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Validate config property injection points #205

merged 1 commit into from
Dec 6, 2018

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 6, 2018

@mkouba
Validate config property injection points
380d700 
- the build should fail if any of the config property is missing and
neither Optional nor ConfigProperty.NULL_VALUE is used
- resolves #199
@mkouba
Copy link
Contributor Author

mkouba commented Dec 6, 2018

BuildShouldFailWith is probably not the best name but Arquillian's ShouldThrowException sounds too general to me.

Also I'm not quite sure if it makes sense to invest more into ShamrockUnitTest or rather create an Arquillian adapter... I'd like to work on the Arq adapter next week as we need it for MP TCKs anyway. So we'll see.

cescoffier
cescoffier approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, works perfectly!

@mkouba
Copy link
Contributor Author

mkouba commented Dec 6, 2018

shamrock-strict-example failed with Caused by: java.net.BindException: Address already in use, Caused by: org.postgresql.util.PSQLException: ERROR: relation "sequencedaddress" already exists and similar errors. Running the build again...

@cescoffier cescoffier mentioned this pull request Dec 6, 2018
Merged
@mkouba
Copy link
Contributor Author

mkouba commented Dec 6, 2018

The build passed locally :-(

@stuartwdouglas
Copy link
Member

I rebased and pushed so I will see if this works, it may have just been a transient failure.

@stuartwdouglas stuartwdouglas merged commit 73fbc96 into quarkusio:master Dec 6, 2018
@cescoffier cescoffier added this to the 0.1.0 milestone Jan 21, 2019
maxandersen added a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@maxandersen
Merge pull request quarkusio#205 from quintesse/fix_win_implicits
4e3be69 
Fixes problem with implicit catalogs not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Application Config should not inject null
3 participants
@mkouba @stuartwdouglas @cescoffier