Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Sort to be empty #20459

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Allow Sort to be empty #20459

merged 1 commit into from
Sep 30, 2021

Conversation

javiertoja
Copy link
Contributor

Fixes #20329.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot
  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@javiertoja javiertoja changed the title Fixes #20329. By adding a new 'empty' method. Fixes #20329. By adding a new 'empty' method Sep 29, 2021
@javiertoja javiertoja changed the title Fixes #20329. By adding a new 'empty' method Allow Sort to be empty Sep 29, 2021
@javiertoja javiertoja marked this pull request as ready for review September 29, 2021 17:16
@Sanne Sanne requested a review from FroMage September 29, 2021 20:05
@geoand geoand requested a review from loicmathieu September 30, 2021 09:48
loicmathieu
loicmathieu approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@loicmathieu loicmathieu merged commit d6d8de6 into quarkusio:main Sep 30, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/panache
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging this pull request may close these issues.

Allow Sort to be empty
2 participants
@javiertoja @loicmathieu