-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch back to IO thread for non blocking requests #20438
Dispatch back to IO thread for non blocking requests #20438
Conversation
I was thinking of the same thing actually. My only question is, does this actually get you back to the same Event Loop thread that security was one? |
It gets you back to the requests event loop thread, security is run on a worker thread. Because this uses the context from the connection it is guaranteed to be the same thread. |
Right, I meant the Security filter that could lead to the dispatch to the worker thread. Sounds good |
We would likely need to do something similar in Reactive Routes, but I assume that can wait since we are deprecating them |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 649d2c7
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/resteasy-reactive-kotlin/standard
📦 integration-tests/resteasy-reactive-kotlin/standard✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/resteasy-reactive-kotlin/standard
📦 integration-tests/resteasy-reactive-kotlin/standard✖
✖
✖
|
649d2c7
to
e54abc3
Compare
requestContext.resume() | ||
//run in a direct invocation executor to run the rest of the invocation in the co-route scope | ||
//feels a bit fragile, but let's see how it goes | ||
requestContext.resume(Executor { it.run() }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoand I needed to do this to make the kotlin tests work. Not sure if I like it much but I think it is probably ok for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can live with it :)
No description provided.