Warn when an OIDC session cookie exceeds 4096 bytes #20431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20363.
This PR adds a warning when a session cookie size is equal or greater than
4096and recommends 3 approaches toward fixing it.It took @artkonr awhile to trace the problem.
We introduced
TokenStateManagerwhen the same problem happened awhile back - but from the trace at #20363 I could not see where the problem was. FYI, @artkonr has verified the recommended 1) and 2) were effective, with 1) being the solution which fitted the use case, but it took me awhile to remember it was possible to do 1) :-).It is all documented, but it would be useful, going forward, to immediately see a warning about the potential problem and try the suggested alternatives