Support the Mutiny AsyncFile type as a return type #20374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| file.close(); | ||
| response.end(); | ||
| // Not sure if I need to resume, actually | ||
| ctx.resume(); |
There was a problem hiding this comment.
out of curiosity, why would resume be not needed here?
There was a problem hiding this comment.
I just copied what Stef had done for the core AsyncFile.
I agree it seems like it's needed...
There was a problem hiding this comment.
Ah, actually it is not needed because the Writers are the last handler.
michalszynkiewicz
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20352