Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension clarification for Kafka Serializer/deserializer autodetection #20361

Merged

Conversation

rsvoboda
Copy link
Member

Extension clarification for Kafka Serializer/deserializer autodetection.

Some people may consider this feature to be available also for quarkus-kafka-client, so let's mention the extension explicitly.

@Ladicek
Copy link
Contributor

Ladicek commented Sep 23, 2021

It does mention the extension explicitly, you're just duplicating the info. If you insist on this, I'd just add the coordinates into backticks so that it's highlighted as code.

@Ladicek Ladicek requested a review from ozangunalp September 23, 2021 14:32
@ozangunalp
Copy link
Contributor

I do agree with @Ladicek on this. At least let's get the backticks so that one can understand that its artifact coordinates.

@rsvoboda rsvoboda force-pushed the kafka.autoserializer.extension.clarification branch from fe92308 to e3df63b Compare September 24, 2021 08:02
@rsvoboda
Copy link
Member Author

Backticks added

@ozangunalp
Copy link
Contributor

Thanks!

@Ladicek Ladicek merged commit 16da213 into quarkusio:main Sep 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants