Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven-publish plugin to fix gradle plugin names #20358

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Sep 23, 2021

This branch adds the maven-publish plugin.

As mention in the message from the gradle team, this should make sure the group id is not prefixes with gradle.plugin.
This looks to be the recommended setup. but there is no way to test it before submitting the plugin :/

Group shouldn't start with gradle.plugin

Under certain circumstances (read on for details), the publishing plugin will use the project group, prefixed with gradle.plugin as the maven coordinate group for your plugin. For example, if your project has group com.foo, the maven coordinate group of the plugin will be gradle.plugin.com.foo. We no longer accept the usage of the gradle.plugin prefix in group values.

The plugin-publish plugin will not do the prefixing described above in case it's used in collaboration with the maven-publish plugin. This is now the recommended setup (see Gradle docs for plugin publishing), so prefixing should no longer happen.

Another way of disabling the automatic prefixing is setting the group via a mavenCoordinates block. See the Full Example below. We will reject plugins if they have a group starting with gradle.plugin so you need to adapt the legacy setup.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Sep 23, 2021
@aloubyansky aloubyansky merged commit 13da2fb into quarkusio:main Sep 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 23, 2021
@glefloch glefloch deleted the fix/gradle-plugin-names branch September 23, 2021 19:30
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants