-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable logging from integration tests #20356
Conversation
Interesting. I suggest to add a note to the docs, otherwise you'll see complaints that logging config is not used. |
I could do that, but I actually want to see if people will complain. If they do, we can apply most of the configuration :) |
😄 ...might be more fair though to document limitations so that users don't waste their time fiddling around with something that won't work in the first place. |
That is certainly a fair point. My thinking is that if we tell users it won't work, they won't be motivated to complain to us to fix it :). In any case, if others think we should add the note, I can certainly do it. |
Right. What about documenting it with a note to raise an issue if interested in a change? |
Yeah, that makes sense. |
Done |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e751640
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/jdbc/jdbc-mssql/deployment
! Skipped: docs integration-tests/jpa-mssql 📦 extensions/jdbc/jdbc-mssql/deployment✖
|
test-framework/junit5/src/main/java/io/quarkus/test/junit/IntegrationTestUtil.java
Show resolved
Hide resolved
32a4909
to
8d8e02a
Compare
@stuartwdouglas is this OK for you now? |
Hi, |
Fixes: #20303