Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging from integration tests #20356

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 23, 2021

Fixes: #20303

@famod
Copy link
Member

famod commented Sep 23, 2021

Interesting. I suggest to add a note to the docs, otherwise you'll see complaints that logging config is not used.

@geoand
Copy link
Contributor Author

geoand commented Sep 23, 2021

I could do that, but I actually want to see if people will complain. If they do, we can apply most of the configuration :)

@famod
Copy link
Member

famod commented Sep 23, 2021

😄 ...might be more fair though to document limitations so that users don't waste their time fiddling around with something that won't work in the first place.
Anyway, I've made my point. 🤷

@geoand
Copy link
Contributor Author

geoand commented Sep 23, 2021

That is certainly a fair point.

My thinking is that if we tell users it won't work, they won't be motivated to complain to us to fix it :).

In any case, if others think we should add the note, I can certainly do it.

@famod
Copy link
Member

famod commented Sep 23, 2021

My thinking is that if we tell users it won't work, they won't be motivated to complain to us to fix it :).

Right. What about documenting it with a note to raise an issue if interested in a change?

@geoand
Copy link
Contributor Author

geoand commented Sep 23, 2021

Yeah, that makes sense.

@geoand
Copy link
Contributor Author

geoand commented Sep 23, 2021

Done

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e751640

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/jdbc/jdbc-mssql/deployment 
! Skipped: docs integration-tests/jpa-mssql 

📦 extensions/jdbc/jdbc-mssql/deployment

io.quarkus.jdbc.mssql.deployment.DevServicesMsSQLDatasourceTestCase. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 63e7ea3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 63e7ea3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs

@geoand
Copy link
Contributor Author

geoand commented Sep 27, 2021

@stuartwdouglas is this OK for you now?

@stuartwdouglas stuartwdouglas merged commit cf07662 into quarkusio:main Sep 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 28, 2021
@geoand geoand deleted the #20303 branch September 28, 2021 06:32
@geoand geoand removed this from the 2.4 - main milestone Sep 28, 2021
@geoand geoand added this to the 2.3.0.Final milestone Sep 28, 2021
@Manfred73
Copy link

Hi,
I ended up here when looking at #20303
What do I need to do to getting logging to work when running @QuarkusIntegrationTest? I still don't see logging from my services.
I'm using quarkus-platform version 2.12.3.Final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging doesn't work on integration test (@QuarkusIntegrationTest)
4 participants