Fix spring-web test failure #20291

stuartwdouglas · 2021-09-21T04:12:12Z

No description provided.

quarkus-bot · 2021-09-21T06:40:55Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `51a867a`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

geoand · 2021-09-21T06:43:47Z

Was this intended to fix the SpringControllerTest.testInvalidJsonInputAndResult failure?

Asking because it was fixed with #20271

stuartwdouglas · 2021-09-21T06:47:56Z

I did not notice that, but do we really want to be adding a resteasy-classic SPI artifact to a resteasy-reactive module?

geoand · 2021-09-21T06:55:10Z

Damn it, you are right...

It's just too hard to review all the RESTEasy stuff in the Github UI... It's just too hard to get mixed up regarding the module that is affected... Now I know to pay much more attention.

Would you like to update this PR with a commit that reverts #20271?

geoand · 2021-09-21T07:06:22Z

Otherwise, I can do it. I just don't want to have the build broken again before the proper fix is in

yrodiere · 2021-09-21T07:32:56Z

I did not notice that, but do we really want to be adding a resteasy-classic SPI artifact to a resteasy-reactive module?

I though that was fine, because the SPI does not depend on resteasy-classic, and it also is very specific to Quarkus. So AFAICS, we could use the same SPI for both.

geoand · 2021-09-21T07:36:05Z

I though that was fine, because the SPI does not depend on resteasy-classic, and it also is very specific to Quarkus. So AFAICS, we could use the same SPI for both.

Technically yeah, it's not a problem. But we really want to the two to be totally separate.

stuartwdouglas · 2021-09-21T07:58:41Z

Should we just have a common SPI module for stuff like this (where it does not actually depend on anything specific to one or the other)?

geoand · 2021-09-21T08:06:54Z

Yeah, for things that are common, that makes sense.

I'll looke into it after 2.3.0.CR1 is out.

stuartwdouglas · 2021-09-22T02:10:56Z

I have added an SPI module just with this class as a starting point.

quarkus-bot · 2021-09-22T06:00:37Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `16ec92c`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Spring	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment integration-tests/spring-web 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ JVM Tests - JDK 16 #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ Native Tests - Spring #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerIT.testInvalidJsonInputAndResult - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

yrodiere

I think the reason tests are still failing is an import that wasn't updated; see below.

...ent/src/main/java/io/quarkus/hibernate/validator/deployment/HibernateValidatorProcessor.java

yrodiere

Damn that was fast.

quarkus-bot · 2021-09-22T10:57:34Z

Failing Jobs - Building `b742826`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
⌛	JVM Tests - JDK 11 Windows	`Upload gc.log`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

stuartwdouglas requested a review from geoand September 21, 2021 04:12

quarkus-bot bot added area/hibernate-validator Hibernate Validator area/rest area/spring Issues relating to the Spring integration labels Sep 21, 2021

geoand approved these changes Sep 21, 2021

View reviewed changes

famod mentioned this pull request Sep 21, 2021

Flaky MultiModuleIncludedBuildTest #20315

Closed

stuartwdouglas force-pushed the fix-build3 branch from 51a867a to 16ec92c Compare September 22, 2021 02:01

quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Sep 22, 2021

stuartwdouglas force-pushed the fix-build3 branch from 16ec92c to 8edd6e2 Compare September 22, 2021 06:29

yrodiere requested changes Sep 22, 2021

View reviewed changes

...ent/src/main/java/io/quarkus/hibernate/validator/deployment/HibernateValidatorProcessor.java Outdated Show resolved Hide resolved

...ent/src/main/java/io/quarkus/hibernate/validator/deployment/HibernateValidatorProcessor.java Show resolved Hide resolved

yrodiere approved these changes Sep 22, 2021

View reviewed changes

Fix spring-web test failure

b742826

stuartwdouglas force-pushed the fix-build3 branch from 8edd6e2 to b742826 Compare September 22, 2021 06:32

geoand approved these changes Sep 22, 2021

View reviewed changes

stuartwdouglas merged commit 98365ed into quarkusio:main Sep 24, 2021

quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021

radcortez mentioned this pull request Oct 21, 2021

Clarify config override rules for multiple application.properties #20943

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix spring-web test failure #20291

Fix spring-web test failure #20291

stuartwdouglas commented Sep 21, 2021

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `51a867a`

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 21, 2021

geoand commented Sep 21, 2021

geoand commented Sep 21, 2021

yrodiere commented Sep 21, 2021

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 21, 2021

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 22, 2021

quarkus-bot bot commented Sep 22, 2021 •

edited

Loading

Failing Jobs - Building `16ec92c`

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/spring-web

⚙️ Native Tests - Spring #

📦 integration-tests/spring-web

yrodiere left a comment

yrodiere left a comment

quarkus-bot bot commented Sep 22, 2021

Fix spring-web test failure #20291

Fix spring-web test failure #20291

Conversation

stuartwdouglas commented Sep 21, 2021

quarkus-bot bot commented Sep 21, 2021 • edited Loading

Failing Jobs - Building 51a867a

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 21, 2021

geoand commented Sep 21, 2021

geoand commented Sep 21, 2021

yrodiere commented Sep 21, 2021

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 21, 2021

geoand commented Sep 21, 2021

stuartwdouglas commented Sep 22, 2021

quarkus-bot bot commented Sep 22, 2021 • edited Loading

Failing Jobs - Building 16ec92c

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/spring-web

⚙️ Native Tests - Spring #

📦 integration-tests/spring-web

yrodiere left a comment

Choose a reason for hiding this comment

yrodiere left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 22, 2021

Failing Jobs - Building b742826

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `51a867a`

quarkus-bot bot commented Sep 22, 2021 •

edited

Loading

Failing Jobs - Building `16ec92c`

Failing Jobs - Building `b742826`