Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource "health-exclude" property should apply to reactive pools too #20273

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

tsegismont
Copy link
Contributor

Closes #20059

In #13375, we got a way to exclude a datasource from health-checks.
Yet the implementation for reactive datasources was missing.

Closes quarkusio#20059

In quarkusio#13375, we got a way to exclude a datasource from health-checks.
Yet the implementation for reactive datasources was missing.
@tsegismont tsegismont changed the title Datasource "health-excluded" property should apply to reactive pools too Datasource "health-exclude" property should apply to reactive pools too Sep 20, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2021

Failing Jobs - Building 93674c8

Status Name Step Failures Logs Raw logs
Native Tests - Misc4 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.nativeimage.CustomNativeTestSourceSetIT.runNativeTests line 18 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmartisk jmartisk merged commit 4d5322b into quarkusio:main Sep 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 21, 2021
@tsegismont tsegismont deleted the issue_20059 branch October 26, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance healthcheck exclude parameter for reactive datasource
3 participants