Add support for Dev Services inside Neo4j module #20269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds one additional processor that conditionally (when docker is working and Neo4j is not reachable on the default address) starts up a Neo4j Test container based on the latest image. Tests have been added that will be executed when docker is enabled. The existing functional integration tests won't be affected as they use explicit configuration.
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
michael-simons
changed the title
mamadaliev
approved these changes
Sep 20, 2021
|
@michael-simons may I ask you to add a paragraph in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.3? I think this is a noteworthy feature and demands bragging about it ;) |
|
Thanks, @gastaldi it's my pleasure. I have created an issue for the Wiki entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds one additional processor that conditionally (when docker is working and Neo4j is not reachable on the default address) starts up a Neo4j Test container based on the latest image.
Tests have been added that will be executed when docker is enabled.
The existing functional integration tests won't be affected as they use explicit configuration.