Deployment performance improvement #20262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valuesWithDefaults can actually be relativly expensive, don't call it unless it is actually needed. Note that 'expensive' in this case is relative as this method is called a lot.
stuartwdouglas
force-pushed
the
minor-perf
branch
from
1963579 to
1e90ec3
Compare
mkouba
approved these changes
Sep 20, 2021
|
I have just been playing around with my bean generator project that simulates a larger app, and in a 2k bean project restart went from 3.7s to 2.7s. This is not representative of a real project by any means, but it is definitely a hotspot. |
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valuesWithDefaults can actually be relativly expensive, don't call it
unless it is actually needed. Note that 'expensive' in this case is
relative as this method is called a lot.