Qute message bundles - fix application class predicate #20204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Sep 16, 2021
mkouba
commented
- resolves io.quarkus.qute.i18n.MessageBundle annotated class *__Bundle not found for multi-module gradle project in test mode #20064
mkouba
commented
Sep 16, 2021
| @@ -1041,8 +1035,7 @@ public boolean test(String name) { | |||
| } | |||
| // E.g. to match the bundle class generated for a localized file; org.acme.Foo_en -> org.acme.Foo | |||
| className = additionalClassNameSanitizer.apply(className); | |||
| return applicationArchives.containingArchive(className) != null | |||
| || GeneratedClassGizmoAdaptor.isApplicationClass(name); | |||
| return GeneratedClassGizmoAdaptor.isApplicationClass(className); | |||
There was a problem hiding this comment.
The main part of the fix is GeneratedClassGizmoAdaptor.isApplicationClass(name) -> GeneratedClassGizmoAdaptor.isApplicationClass(className)!
mkouba
added
the
triage/waiting-for-ci
geoand
approved these changes
Sep 16, 2021
|
I assume this should be backported, right? |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.