-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Spring Web to RESTEasy Reactive #20195
Conversation
This means that the Spring Web can now longer be used with RESTEasy Classic which means the loss of the following functionality: * XML support via the JAX-B extension * Support for Servlet types The port however brings the following benefits: * Aligns with the move to make RESTEasy Reactive the default REST layer * Improves runtime performance * Allows up to better support this module as all the necessary code is owned by Quarkus instead of being split between Quarkus and RESTEasy Classic
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 956308b
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-openapi/deployment
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 132 more 📦 extensions/smallrye-openapi/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/smallrye-openapi/deployment
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 132 more 📦 extensions/smallrye-openapi/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #- Failing: extensions/smallrye-openapi/deployment
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 132 more 📦 extensions/smallrye-openapi/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
This is done to avoid having the OpenAPI test module depend on both RESTEasy Classic and RESTEasy Reactive
956308b
to
76768cd
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 76768cd
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
✖
✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
@glefloch the gradle test failures seem unrelated, no? |
@geoand yes, they are not related to this PR. |
Thanks for confirmation! |
Failing Jobs - Building 76768cd
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
|
...main/java/org/jboss/resteasy/reactive/common/processor/scanning/ResteasyReactiveScanner.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Awesome job! 🥳
@stuartwdouglas any objections to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't really know anything about Spring.
Sure, I just wanted to know whether you had any general objections :) |
This means that the Spring Web can now longer
be used with RESTEasy Classic which means
the loss of the following functionality:
The port however brings the following benefits: