Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocation of the quarkus-vertx-web extension #20189

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

cescoffier
Copy link
Member

The renaming of the quarkus-vertx-web extension to quarkus-reactive-routes is a breaking change.
This PR introduces a Maven relocation and so allows a smooth transition. Applications using the old artifact will get relocated automatically. A warning is displayed in the log indicating the relocation.

…outes is a breaking change.

This commit introduces a Maven relocation and so allows a smooth transition. Applications using the old artifact will get relocated automatically. A warning is displayed in the log indicating the relocation.
@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Sep 16, 2021
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and it really works!

@mkouba
Copy link
Contributor

mkouba commented Sep 16, 2021

I will update the migration guide as well.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2021
@cescoffier cescoffier changed the title quarkus-vertx-web relocation Relocation of the quarkus-vertx-web extension Sep 16, 2021
@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gastaldi
Copy link
Contributor

@glefloch any idea why so many (flaky?) Gradle errors in this PR?

@mkouba
Copy link
Contributor

mkouba commented Sep 16, 2021

@glefloch any idea why so many (flaky?) Gradle errors in this PR?

It's not this PR only: #20165 (comment)

@glefloch
Copy link
Member

@gastaldi not they are not, it looks like gradle is not able to get plugins. There is an issue with bintray (which is used by the portal) this could come from that.

@gastaldi
Copy link
Contributor

I triggered the CI jobs again, let's see how that goes

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2021

Failing Jobs - Building 777eb9f

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit ac59cf9 into quarkusio:main Sep 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 16, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2021
@cescoffier cescoffier deleted the vertx-web-relocations branch March 15, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants