Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue Swagger UI doc #20172

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Fix issue Swagger UI doc #20172

merged 1 commit into from
Sep 15, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 15, 2021

Without the fix, it rendered like this:

Screenshot from 2021-09-15 17-59-29

gastaldi
gastaldi approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gastaldi gastaldi merged commit cd1c5e3 into quarkusio:main Sep 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 15, 2021
@gastaldi gastaldi deleted the swagger-doc-fix branch September 15, 2021 16:22
@geoand
Copy link
Contributor Author

geoand commented Sep 15, 2021

👌

phillip-kruger
phillip-kruger approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should actually be hidden, that is why we have not seen this before. We might need a new metadata field to indicate that some extension should be hidden in Dev UI.

@gsmet gsmet modified the milestones: 2.3.0.CR1, 2.2.4.Final Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.2.4.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @gastaldi @phillip-kruger @gsmet