-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce build item that gives access to generated k8s resources #20113
Conversation
This is useful for extensions that depend on the k8s extension in order to have a predicable way to use the output of the kubernetes extension
cc @metacosm |
Failing Jobs - Building 7ca2664
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Security2 #📦 integration-tests/oidc✖
|
Isn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think not, cause it's more generic than we need. |
@iocanel is exactly right. The existing build item contains all generated resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any chance that could be backported to 2.2? |
You should know by know, look at the labels 😉 |
Ah yes, that wasn't obvious on the GitHub app, sorry. |
NP! |
This relies on newly introduced GeneratedKubernetesResourceBuildItem from quarkusio/quarkus#20113 which would need to be backported.
This relies on newly introduced GeneratedKubernetesResourceBuildItem from quarkusio/quarkus#20113 which would need to be backported.
This relies on newly introduced GeneratedKubernetesResourceBuildItem from quarkusio/quarkus#20113 which would need to be backported.
Sorry for the noise @gsmet. I added the backport label by accident. |
This is useful for extensions that depend on the k8s extension
in order to have a predicable way to use the output of the
kubernetes extension