Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce build item that gives access to generated k8s resources #20113

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 13, 2021

This is useful for extensions that depend on the k8s extension
in order to have a predicable way to use the output of the
kubernetes extension

This is useful for extensions that depend on the k8s extension
in order to have a predicable way to use the output of the
kubernetes extension
@geoand
Copy link
Contributor Author

geoand commented Sep 13, 2021

cc @metacosm

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 13, 2021

Failing Jobs - Building 7ca2664

Status Name Step Failures Logs Raw logs
Native Tests - Security2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc

io.quarkus.it.keycloak.HelloResourceIT.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:250)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:65)

@gastaldi
Copy link
Contributor

Isn't GeneratedFileSystemResourceBuildItem already doing this?

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel
Copy link
Contributor

iocanel commented Sep 14, 2021

GeneratedFileSystemResourceBuildItem

I think not, cause it's more generic than we need.

@geoand
Copy link
Contributor Author

geoand commented Sep 14, 2021

@iocanel is exactly right.

The existing build item contains all generated resources.

@geoand geoand merged commit 91d96c7 into quarkusio:main Sep 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 14, 2021
@geoand geoand deleted the k8s-generated-resources branch September 14, 2021 05:53
Copy link
Contributor

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm
Copy link
Contributor

Any chance that could be backported to 2.2?

@geoand
Copy link
Contributor Author

geoand commented Sep 14, 2021

You should know by know, look at the labels 😉

@metacosm
Copy link
Contributor

Ah yes, that wasn't obvious on the GitHub app, sorry.

@geoand
Copy link
Contributor Author

geoand commented Sep 14, 2021

NP!

metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this pull request Sep 14, 2021
This relies on newly introduced GeneratedKubernetesResourceBuildItem
from quarkusio/quarkus#20113 which would need
to be backported.
metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this pull request Oct 5, 2021
This relies on newly introduced GeneratedKubernetesResourceBuildItem
from quarkusio/quarkus#20113 which would need
to be backported.
metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this pull request Oct 6, 2021
This relies on newly introduced GeneratedKubernetesResourceBuildItem
from quarkusio/quarkus#20113 which would need
to be backported.
@gsmet gsmet modified the milestones: 2.3.0.CR1, 2.2.4.Final Nov 30, 2021
@paulrobinson
Copy link
Contributor

Sorry for the noise @gsmet. I added the backport label by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants