Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC bean resolution - handle qualifier default values correctly #20097

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

@mkouba mkouba requested review from manovotn and Ladicek September 13, 2021 14:02
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 13, 2021
@mkouba mkouba added this to the 2.3 - main milestone Sep 13, 2021
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8a85f14

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 16 Build Failures Logs Raw logs
Native Tests - gRPC Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-912a8d1f-a6a1-4b33-a80f-19d3a15ebc13

org.acme.GreetingResourceTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type org.acme.HelloGrpc and qualifiers [@GrpcClient]

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-1a4ee45f-6864-4c0a-99f5-63b0199204e2

org.acme.GreetingControllerTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type org.acme.HelloGrpc and qualifiers [@GrpcClient]

⚙️ JVM Tests - JDK 11 #

- Failing: devtools/cli extensions/grpc/deployment 
! Skipped: docs integration-tests/devmode integration-tests/grpc-health and 9 more

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

📦 extensions/grpc/deployment

io.quarkus.grpc.client.ClientWithoutConfigInjectionTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.lock.detection.BlockingClientCallOnEventLoopTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.ClientCallFromBlockingServiceTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.BlockingOnClassTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.TransactionalAsBlockingTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

io.quarkus.grpc.server.interceptors.GlobalAndServiceInterceptorsTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/cli extensions/grpc/deployment 
! Skipped: docs integration-tests/devmode integration-tests/grpc-health and 9 more

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

📦 extensions/grpc/deployment

io.quarkus.grpc.client.ClientWithoutConfigInjectionTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.lock.detection.BlockingClientCallOnEventLoopTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.ClientCallFromBlockingServiceTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.BlockingOnClassTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.TransactionalAsBlockingTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

io.quarkus.grpc.server.interceptors.GlobalAndServiceInterceptorsTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

⚙️ JVM Tests - JDK 16 #

- Failing: devtools/cli extensions/grpc/deployment 
! Skipped: docs integration-tests/devmode integration-tests/grpc-health and 9 more

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

📦 extensions/grpc/deployment

io.quarkus.grpc.client.ClientWithoutConfigInjectionTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.lock.detection.BlockingClientCallOnEventLoopTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.ClientCallFromBlockingServiceTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.BlockingOnClassTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:

io.quarkus.grpc.server.blocking.TransactionalAsBlockingTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

io.quarkus.grpc.server.interceptors.GlobalAndServiceInterceptorsTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: Found 3 deployment problems:

⚙️ Native Tests - gRPC #

- Failing: integration-tests/grpc-streaming 

📦 integration-tests/grpc-streaming

io.quarkus.grpc.example.streaming.StreamingEndpointTest.testPipe - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.grpc.examples.streaming.MutinyStreamingGrpc$MutinyStreamingStub and qualifiers [@GrpcClient]

@mkouba
Copy link
Contributor Author

mkouba commented Sep 14, 2021

It seems that at least some of the gRPC CI failures are related. I'll need to find the cause...

@mkouba mkouba requested review from Ladicek and manovotn September 14, 2021 09:09
@mkouba mkouba force-pushed the arc-qualifier-default-values-bug branch from 8a85f14 to 22725af Compare September 14, 2021 09:13
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Sep 14, 2021
@mkouba mkouba force-pushed the arc-qualifier-default-values-bug branch from 22725af to e8fad02 Compare September 14, 2021 09:19
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e8fad02

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 16 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@mkouba
Copy link
Contributor Author

mkouba commented Sep 14, 2021

Hm, LambdaDevServicesContinuousTestingTestCase.testLambda() does not fail locally for me. Let's try again.

@gastaldi
Copy link
Contributor

This is a known flaky test that also fails in other PRs too, you can merge this safely 😉

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e8fad02

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kafka-avro-apicurio2 

📦 integration-tests/kafka-avro-apicurio2

io.quarkus.it.kafka.KafkaAvroTest.testApicurioAvroProducer - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:574)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:647)

@gastaldi
Copy link
Contributor

Apparently the Lambda failure is related to the changes introduced in c3baf65, I'm investigating what's wrong

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e8fad02

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 16
Native Tests - Data1 Build Failures Logs Raw logs
Native Tests - Misc4 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ Native Tests - Data1 #

- Failing: integration-tests/jpa-mssql 

📦 integration-tests/jpa-mssql

Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-jpa-mssql: I/O Error


⚙️ Native Tests - Misc4 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.nativeimage.BasicJavaNativeBuildIT.shouldBuildNativeImage line 27 - More details - Source on GitHub

java.lang.AssertionError: 
native-image build log is missing certain expected log messages:

io.quarkus.gradle.nativeimage.CustomNativeTestSourceSetIT.runNativeTests line 18 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 15, 2021

Failing Jobs - Building e8fad02

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

@mkouba mkouba merged commit 8f1fa77 into quarkusio:main Sep 15, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 15, 2021
@gsmet gsmet removed this from the 2.3.0.CR1 milestone Nov 30, 2021
@gsmet gsmet added this to the 2.2.4.Final milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/grpc gRPC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants