Use quarkus-gradle-plugin.version property in the JSON metadata template to represent the version of the Gradle plugin #20029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
gastaldi
reviewed
Sep 9, 2021
| @@ -131,7 +131,7 @@ | |||
| "maven-plugin-artifactId": "quarkus-maven-plugin", | |||
| "maven-plugin-version": "${project.version}", | |||
| "gradle-plugin-id": "io.quarkus", | |||
| "gradle-plugin-version": "${project.version}", | |||
| "gradle-plugin-version": "${quarkus-gradle-plugin.version}", | |||
There was a problem hiding this comment.
Why a different property? maven-plugin-version above uses the project.version too and I don't remember seeing any problem with it
There was a problem hiding this comment.
I added one for the Maven plugin as well for consistency. Depending on the Quarkus (platform) build, Maven and Gradle plugins may be different.
…operty in the JSON metadata template to represent the Quarkus plugin versions
aloubyansky
force-pushed
the
gradle-plugin-version-prop
branch
from
819c718 to
a2f09c5
Compare
gastaldi
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.