Add missing @PathParam value in examples #20006
Conversation
|
These aren't really missing, but they imply that |
|
ok, should we specify it somehow ? or keep it as is ? |
|
We can include the full class name, that would make it unambiguous. However, we are likely going to move to RESTEasy Reactive as the default, and there the annotation has a different name. |
| @@ -287,7 +287,7 @@ public class GreetingResource { | |||
| @GET | |||
| @Produces(MediaType.TEXT_PLAIN) | |||
| @Path("/greeting/{name}") | |||
| public String greeting(@PathParam String name) { | |||
| public String greeting(@PathParam("name") String name) { | |||
There was a problem hiding this comment.
Nope. We are using org.jboss.resteasy.annotations.jaxrs.PathParam, not the JAX-RS @PathParam and the RESTEasy one doesn't require the name.
And if something needs fixing, it would be making sure the imports are always there so that's it's clear. Typically, in this case, the imports are there.
There was a problem hiding this comment.
they are almost present everywhere, I will add the missing ones.
glefloch
force-pushed
the
fix/path-param-docs
branch
from
e0c6273 to
afb20ca
Compare
|
@gsmet I added missing imports, should we merge this? |
This adds missing value on
@PathParamannotation examples.