-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link to Swagger UI from OIDC Dev UI Screen #20005
Added link to Swagger UI from OIDC Dev UI Screen #20005
Conversation
Signed-off-by:Phillip Kruger <[email protected]>
// In dev mode, default to persist Authorization true | ||
if (!swaggerUiConfig.persistAuthorization.isPresent()) { | ||
swaggerUiConfig.persistAuthorization = Optional.of(true); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making it an Optional
, isn't easier to define as a boolean
with true
as the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this is that there is actually no default. In dev mode we make it true
, except if explicitly set false
by the user. In other modes it will be false
. except if explicitly set true
by the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is that it's not common to change config values in a processor, so perhaps this could be tested when this value is consumed instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets consumed in SmallRye, and there we do not have the concept of dev mode...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phillip-kruger Very nice, thanks for making it happen, look forward to documenting it :-)
Should this be backported? |
This PR allows you to navigate from the OIDC DEV UI screen to Swagger (if included) in a logged in state.
Signed-off-by:Phillip Kruger [email protected]