Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to Swagger UI from OIDC Dev UI Screen #20005

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Added link to Swagger UI from OIDC Dev UI Screen #20005

merged 1 commit into from
Sep 8, 2021

Conversation

phillip-kruger
Copy link
Member

This PR allows you to navigate from the OIDC DEV UI screen to Swagger (if included) in a logged in state.

test_with_swagger

Signed-off-by:Phillip Kruger [email protected]

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/oidc area/swagger-ui labels Sep 8, 2021
Comment on lines +125 to +128
// In dev mode, default to persist Authorization true
if (!swaggerUiConfig.persistAuthorization.isPresent()) {
swaggerUiConfig.persistAuthorization = Optional.of(true);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making it an Optional, isn't easier to define as a boolean with true as the default value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is that there is actually no default. In dev mode we make it true, except if explicitly set false by the user. In other modes it will be false. except if explicitly set true by the user

Copy link
Contributor

@gastaldi gastaldi Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that it's not common to change config values in a processor, so perhaps this could be tested when this value is consumed instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets consumed in SmallRye, and there we do not have the concept of dev mode...

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillip-kruger Very nice, thanks for making it happen, look forward to documenting it :-)

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 8, 2021
@sberyozkin
Copy link
Member

CC @sebastienblanc

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2021

Failing Jobs - Building b001d1a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

@geoand
Copy link
Contributor

geoand commented Sep 8, 2021

Should this be backported?

@gastaldi gastaldi merged commit e11f58b into quarkusio:main Sep 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 8, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 8, 2021
@phillip-kruger phillip-kruger deleted the swagger-link-keycloak-devui branch September 9, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/oidc area/swagger-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants