Rest Client Reactive: SmallRye Stork integration #19998

michalszynkiewicz · 2021-09-08T11:31:12Z

No description provided.

bom/application/pom.xml

...asy-reactive/rest-client-reactive/deployment/src/test/resources/stork-application.properties

cescoffier · 2021-09-08T11:59:40Z

...esteasy-reactive/rest-client-reactive/deployment/src/test/resources/stork-stat-lb.properties

+stork.hello-service.service-discovery.1=${quarkus.http.host}:${quarkus.http.test-port}
+stork.hello-service.service-discovery.2=localhost:8766
+stork.hello-service.load-balancer=stat-based
+hello2/mp-rest/url=stork://hello-service/hello


Unrelated to stork, but I still find the MP Rest client format odd, especially when used with the more regular format.

extensions/resteasy-reactive/rest-client-reactive/runtime/pom.xml

...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java

aureamunoz

LGTM

...asy-reactive/rest-client-reactive/deployment/src/test/resources/stork-application.properties

geoand · 2021-09-08T13:51:04Z

I'll try and take a look tomorrow.

Has it been tested in native?
How about dev-mode?

michalszynkiewicz · 2021-09-09T06:36:42Z

I'll try and take a look tomorrow.

Has it been tested in native?
How about dev-mode?

No, I'll add a native test, and if I can a dev mode test too

geoand · 2021-09-09T07:20:50Z

:+1

...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java

geoand

Some mention of Stork will also need to appear in the reference documentation that you need to write for the REST Client :)

michalszynkiewicz · 2021-09-09T07:36:57Z

Some mention of Stork will also need to appear in the reference documentation that you need to write for the REST Client :)

sure thing

quarkus-bot · 2021-09-16T11:10:27Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b4610e5`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 7 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.16.0:validate (default) on project quarkus-rest-client-reactive-deployment: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-reactive/rest-client-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/stork/StorkDevModeTest.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot · 2021-09-16T16:00:09Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `490c935`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main line 21 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:259)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$2(TestMethodTestDescriptor.java:163)

✖ io.quarkus.rest.client.reactive.stork.StorkIntegrationTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

✖ io.quarkus.rest.client.reactive.stork.StorkResponseTimeLoadBalancerTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 286 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:259)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$2(TestMethodTestDescriptor.java:163)

✖ io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.TestFailingBeforeAllTestCase.testBrokenBeforeAllHandling line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 45 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 43 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.metaannotations.MetaAnnotationsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.params.TestParameterizedTestCase.testParameterizedTests line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <4> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 42 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkIntegrationTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

✖ io.quarkus.rest.client.reactive.stork.StorkResponseTimeLoadBalancerTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

quarkus-bot · 2021-09-17T01:50:14Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `522b003`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:259)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$2(TestMethodTestDescriptor.java:163)

✖ io.quarkus.rest.client.reactive.stork.StorkIntegrationTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkIntegrationTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

✖ io.quarkus.rest.client.reactive.stork.StorkResponseTimeLoadBalancerTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)

...ctive-stork/src/test/java/io/quarkus/it/rest/reactive/stork/RestClientReactiveStorkTest.java

...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java

geoand · 2021-09-17T12:48:56Z

...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java

@@ -129,13 +160,18 @@ void registerRestClientListenerForTracing(
    }

    @BuildStep
-    @Record(ExecutionTime.STATIC_INIT)
+    @Record(ExecutionTime.RUNTIME_INIT)


Why this change? Can't we just have stork in its own build step that will use the runtime init phase?

I wonder how much we can do at build time. At least having a Stock build item would be good.

good catch, I need only Stork initialization moved to runtime

@cescoffier what would be the purpose of the stork build item? Mark that initialization is done?

@geoand fixed

Still trying to see what would be possible. Typically, can we check at build time that the configured discovery and load balancing strategy exist.

That would mean that service discovery type has to be build time fixed, no?
I'm not sure we want that

cescoffier · 2021-09-19T17:55:53Z

Start to looks good. I wonder what we can handle at build time (see @geoand's comment). I need to think about the configuration, as configuring both stock and the rest-client looks a bit "extra-step-required".

...asy-reactive/rest-client-reactive/deployment/src/test/resources/stork-application.properties

cescoffier · 2021-09-19T17:57:19Z

...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java

@@ -129,13 +160,18 @@ void registerRestClientListenerForTracing(
    }

    @BuildStep
-    @Record(ExecutionTime.STATIC_INIT)
+    @Record(ExecutionTime.RUNTIME_INIT)


I wonder how much we can do at build time. At least having a Stock build item would be good.

quarkus-bot · 2021-09-20T15:50:14Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `9a09762`

Status	Name	Step	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Spring	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsKotlin line 61 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsKotlin line 61 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-c527dbb5-3794-4592-a612-08f511a6450a

✖ org.acme.GreetingControllerTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same properties (e.g. including both reactive and blocking database extensions)
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same...

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-37e22e77-0002-4f35-b0ba-554c05d0e4cf

✖ org.acme.GreetingControllerTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same properties (e.g. including both reactive and blocking database extensions)
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same...

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsKotlin line 61 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsKotlin line 61 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 73 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 56 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 80 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-4b96d3da-f5bd-49d9-ad94-024ec2849b6a

✖ org.acme.GreetingControllerTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same properties (e.g. including both reactive and blocking database extensions)
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same...

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-300ab611-4107-418f-9d39-52351ffc974f

✖ org.acme.GreetingControllerTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same properties (e.g. including both reactive and blocking database extensions)
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "security.jaxrs.deny-unannotated-endpoints" property was matched by both public boolean io.quarkus.resteasy.reactive.common.runtime.JaxRsSecurityConfig.denyJaxRs and public boolean io.quarkus.resteasy.runtime.JaxRsSecurityConfig.denyJaxRs. This is likely because you have an incompatible combination of extensions that both define the same...

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ Native Tests - Spring #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerIT.testInvalidJsonInputAndResult - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

quarkus-bot · 2021-09-21T10:15:33Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a2b188c`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Spring	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerTest.testInvalidJsonInputAndResult line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

⚙️ Native Tests - Spring #

- Failing: integration-tests/spring-web

📦 integration-tests/spring-web

✖ io.quarkus.it.spring.web.SpringControllerIT.testInvalidJsonInputAndResult - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <500>.

michalszynkiewicz · 2021-09-21T15:07:29Z

failures don't look related

cescoffier

LGTM

quarkus-bot · 2021-10-04T07:20:14Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `2f2740b`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 7 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-rest-client-reactive-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/resteasy-reactive/rest-client-reactive/deployment/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java

michalszynkiewicz · 2021-10-04T09:46:23Z

the MP TCK failure seems unrelated, it fails on the fault tolerance TCK

quarkus-bot · 2021-10-04T16:28:16Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `1874920`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 64 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 64 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 6 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 64 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

quarkus-bot · 2021-10-04T23:13:41Z

Failing Jobs - Building `ec20dd3`

Status	Name	Step	Failures	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/rest labels Sep 8, 2021

michalszynkiewicz requested review from cescoffier, FroMage, aureamunoz, geoand and stuartwdouglas September 8, 2021 11:35

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from a599860 to caa3d39 Compare September 8, 2021 11:37

cescoffier requested changes Sep 8, 2021

View reviewed changes

aureamunoz approved these changes Sep 8, 2021

View reviewed changes

...asy-reactive/rest-client-reactive/deployment/src/test/resources/stork-application.properties Show resolved Hide resolved

geoand reviewed Sep 9, 2021

View reviewed changes

...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java Outdated Show resolved Hide resolved

geoand reviewed Sep 9, 2021

View reviewed changes

...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java Outdated Show resolved Hide resolved

geoand reviewed Sep 9, 2021

View reviewed changes

michalszynkiewicz force-pushed the rest-client-reactive-stork branch 2 times, most recently from 1dac7b7 to b4610e5 Compare September 16, 2021 10:53

michalszynkiewicz marked this pull request as ready for review September 16, 2021 10:55

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from b4610e5 to 490c935 Compare September 16, 2021 11:35

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 490c935 to 522b003 Compare September 16, 2021 21:40

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 522b003 to 87611ba Compare September 17, 2021 06:57

geoand reviewed Sep 17, 2021

View reviewed changes

...ctive-stork/src/test/java/io/quarkus/it/rest/reactive/stork/RestClientReactiveStorkTest.java Outdated Show resolved Hide resolved

geoand reviewed Sep 17, 2021

View reviewed changes

...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java Outdated Show resolved Hide resolved

geoand reviewed Sep 17, 2021

View reviewed changes

cescoffier self-requested a review September 17, 2021 13:03

cescoffier requested changes Sep 19, 2021

View reviewed changes

michalszynkiewicz force-pushed the rest-client-reactive-stork branch 2 times, most recently from ad2c66c to 9a09762 Compare September 20, 2021 11:18

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 9a09762 to a2b188c Compare September 21, 2021 05:49

cescoffier approved these changes Oct 1, 2021

View reviewed changes

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from a2b188c to 2f2740b Compare October 4, 2021 07:04

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 2f2740b to 992a388 Compare October 4, 2021 07:34

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 992a388 to 1874920 Compare October 4, 2021 11:37

Rest Client Reactive: SmallRye Stork integration

ec20dd3

michalszynkiewicz force-pushed the rest-client-reactive-stork branch from 1874920 to ec20dd3 Compare October 4, 2021 18:35

michalszynkiewicz merged commit c873a41 into quarkusio:main Oct 5, 2021

quarkus-bot bot added this to the 2.4 - main milestone Oct 5, 2021

Rest Client Reactive: SmallRye Stork integration #19998

Rest Client Reactive: SmallRye Stork integration #19998

Conversation

michalszynkiewicz commented Sep 8, 2021

Choose a reason for hiding this comment

aureamunoz left a comment

Choose a reason for hiding this comment

geoand commented Sep 8, 2021

michalszynkiewicz commented Sep 9, 2021

geoand commented Sep 9, 2021

geoand left a comment

Choose a reason for hiding this comment

michalszynkiewicz commented Sep 9, 2021

quarkus-bot bot commented Sep 16, 2021 • edited Loading

Failing Jobs - Building b4610e5

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

quarkus-bot bot commented Sep 16, 2021 • edited Loading

Failing Jobs - Building 490c935

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

quarkus-bot bot commented Sep 17, 2021 • edited Loading

Failing Jobs - Building 522b003

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cescoffier commented Sep 19, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 20, 2021 • edited Loading

Failing Jobs - Building 9a09762

Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-c527dbb5-3794-4592-a612-08f511a6450a

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-37e22e77-0002-4f35-b0ba-554c05d0e4cf

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-4b96d3da-f5bd-49d9-ad94-024ec2849b6a

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-kotlin-300ab611-4107-418f-9d39-52351ffc974f

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/spring-web

⚙️ Native Tests - Spring #

📦 integration-tests/spring-web

quarkus-bot bot commented Sep 21, 2021 • edited Loading

Failing Jobs - Building a2b188c

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/spring-web

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/spring-web

⚙️ Native Tests - Spring #

📦 integration-tests/spring-web

michalszynkiewicz commented Sep 21, 2021

cescoffier left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Oct 4, 2021 • edited Loading

Failing Jobs - Building 2f2740b

quarkus-bot bot commented Sep 16, 2021 •

edited

Loading

Failing Jobs - Building `b4610e5`

quarkus-bot bot commented Sep 16, 2021 •

edited

Loading

Failing Jobs - Building `490c935`

quarkus-bot bot commented Sep 17, 2021 •

edited

Loading

Failing Jobs - Building `522b003`

quarkus-bot bot commented Sep 20, 2021 •

edited

Loading

Failing Jobs - Building `9a09762`

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `a2b188c`

quarkus-bot bot commented Oct 4, 2021 •

edited

Loading

Failing Jobs - Building `2f2740b`

quarkus-bot bot commented Oct 4, 2021 •

edited

Loading

Failing Jobs - Building `1874920`

Failing Jobs - Building `ec20dd3`