-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the getting started documentation when building an uber-jar #19992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0ada442
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: independent-projects/tools/devtools-testing
! Skipped: devtools/cli integration-tests/container-image/maven-invoker-way integration-tests/kotlin and 3 more 📦 independent-projects/tools/devtools-testing✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: independent-projects/tools/devtools-testing
! Skipped: devtools/cli integration-tests/container-image/maven-invoker-way integration-tests/kotlin and 3 more 📦 independent-projects/tools/devtools-testing✖
⚙️ MicroProfile TCKs Tests #- Failing: tcks/resteasy-reactive
📦 tcks/resteasy-reactive✖ 📦 tcks/resteasy-reactive/target/testsuite/tests✖
⚙️ Native Tests - Data3 #- Failing: integration-tests/liquibase
📦 integration-tests/liquibase✖ |
It seems like |
Let me try to fix it |
Should be fixed, @geoand can you approve the workflow? |
It's been approved :). One last thing if you don't mind, can you please squash the commits? Thanks |
@geoand no problem, here is the squashed commit! Can you approve the workflow again? |
Thanks! It's ready to go |
Failing Jobs - Building 587b2ba
Full information is available in the Build summary check run. Failures⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
|
The "getting started" documentation isn't clear when you want to build an uber-jar, as the command that is given only works for exploded JARs. This is trying to clarify it.