Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the getting started documentation when building an uber-jar #19992

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

jdubois
Copy link
Contributor

@jdubois jdubois commented Sep 8, 2021

The "getting started" documentation isn't clear when you want to build an uber-jar, as the command that is given only works for exploded JARs. This is trying to clarify it.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 8, 2021
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes area/documentation and removed area/platform Issues related to definition and interaction with Quarkus Platform area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Sep 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0ada442

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs
Native Tests - Data3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli integration-tests/container-image/maven-invoker-way integration-tests/kotlin and 3 more

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateDefault(TestInfo) line 56 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to udpate it automatically): QuarkusCodestartGenerationTest/generateDefault/README.md] 
Path:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli integration-tests/container-image/maven-invoker-way integration-tests/kotlin and 3 more

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateDefault(TestInfo) line 56 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to udpate it automatically): QuarkusCodestartGenerationTest/generateDefault/README.md] 
Path:

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/resteasy-reactive 

📦 tcks/resteasy-reactive

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (test) on project quarkus-tck-resteasy-reactive: Command execution failed.

📦 tcks/resteasy-reactive/target/testsuite/tests

com.sun.ts.tests.jaxrs.platform.container.completioncallback.JAXRSClient0164.argumentIsNullWhenRegistredClassTest line 209 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.common.JAXRSCommonClient$Fault: Unexpected response content No name has been set yet expecting NULL
	at com.sun.ts.tests.jaxrs.platform.container.completioncallback.JAXRSClient0164.assertString(JAXRSClient0164.java:458)
	at com.sun.ts.tests.jaxrs.platform.container.completioncallback.JAXRSClient0164.argumentIsNullWhenRegistredClassTest(JAXRSClient0164.java:209)

⚙️ Native Tests - Data3 #

- Failing: integration-tests/liquibase 

📦 integration-tests/liquibase

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-liquibase: Failed to build quarkus application

@geoand
Copy link
Contributor

geoand commented Sep 8, 2021

It seems like io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest breaks.
Do you want to fix it or should I push an to the PR?

@jdubois
Copy link
Contributor Author

jdubois commented Sep 8, 2021

Let me try to fix it

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 8, 2021
@jdubois
Copy link
Contributor Author

jdubois commented Sep 8, 2021

Should be fixed, @geoand can you approve the workflow?

@geoand
Copy link
Contributor

geoand commented Sep 8, 2021

It's been approved :).

One last thing if you don't mind, can you please squash the commits?
We use a merge commit strategy and the GitHub UI doesn't allow for both squashing and creating a merge commit.

Thanks

@jdubois
Copy link
Contributor Author

jdubois commented Sep 8, 2021

@geoand no problem, here is the squashed commit! Can you approve the workflow again?

@geoand
Copy link
Contributor

geoand commented Sep 8, 2021

Thanks!

It's ready to go

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 9, 2021

Failing Jobs - Building 587b2ba

Status Name Step Failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.JarRunnerIT.testThatFastJarCustomOutputDirFormatWorks line 180 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

io.quarkus.maven.it.JarRunnerIT.testThatFastJarCustomOutputDirFormatWorks line 180 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@geoand geoand merged commit 13b65be into quarkusio:main Sep 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 9, 2021
@geoand geoand removed triage/waiting-for-ci Ready to merge when CI successfully finishes area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants