-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for provider-neutral OIDC Dev UI #19969
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 79a43d7
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
⚙️ JVM Tests - JDK 16 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some Tests cases failing ? I think the tests needs updating ?
79a43d7
to
a93629f
Compare
@phillip-kruger Hi Phillip, thanks, yes, just fixed it - as the title is now set dynamically, |
@phillip-kruger @stuartwdouglas thanks, I've been thinking since yesterday about experimenting with the way it is all named depending on whether it is Keycloak or not, but I'll give it a try a bit later |
Fixes #18427.
This PR simply makes Dev UI page which is currently only shown when
Dev Services for Keycloak
is started visible whenquarkus.oidc.auth-server-url
already points to a started Keycloak or indeed any other OpenId Connect provider which support the auto-discovery.As far as the
provider.html
is concerned I just had to do a fewifs/elses
as a provider likeAuth0
does not return a logout URL, and also does not support returning the code as URL fragment, and do a few minor updates to avoid assuming that all provider URLs are Keycloak based.Finally I had to move a few handlers to the
quarkus.oidc.devservices
package to reuse betweenDev Services for Keycloak
and genericOpenId Connect Dev Console
- both are supported by the sameprovider.html
.Tested with
Keycloak
andAuth0
.In a follow up PR I'll do a bit more work to support more token grants with non-Keycloak providers.