Default to drop-and-create for DevServices #19951

stuartwdouglas · 2021-09-07T05:50:45Z

This allows for hibernate to be used without configuration.

stuartwdouglas · 2021-09-07T05:51:57Z

@Sanne in this case we know that we just started the container, so we know there is no schema there (unless they have used a custom image with the schema in it). I think this makes sense in terms of making this 'just work' out of the box.

gsmet

Added a minor gripe: that's how it's documented everywhere now so let's be consistent.

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

...src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java

quarkus-bot · 2021-09-07T07:39:27Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f56f305`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

Sanne · 2021-09-07T08:36:27Z

Nice idea, thanks!

I wonder if the check on JdbcDataSourceSchemaReadyBuildItem is enough for getting a consistent experience though, as it's merely controlling the phase in which schema management needs to happen (for ordering), but it doesn't really tell

if schemas are actually being generated
which ones, in case of multiple datasources

I'll play a bit more with it to see if I'm missing something.

geoand · 2021-09-07T08:43:00Z

I was actually thinking about this yesterday when creating a demo. Definitely +1 from me for the idea.

Sanne · 2021-09-07T08:58:16Z

Ok looks like this isn't too tricky when there are multiple PUs, works fine even on non-default PUs - although obviously one is no longer able to run "fully configuration-less"

quarkus-bot · 2021-09-07T09:44:50Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c4434d3`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 10 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

quarkus-bot · 2021-09-08T02:24:11Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `3ecce72`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

quarkus-bot · 2021-09-08T05:44:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b3b89ca`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/panache/hibernate-orm-panache/deployment 
! Skipped: docs extensions/panache/hibernate-orm-rest-data-panache/deployment extensions/security-jpa/deployment and 11 more

📦 extensions/panache/hibernate-orm-panache/deployment

✖ io.quarkus.hibernate.orm.panache.deployment.test.PanacheJAXBTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:553)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)

This allows for hibernate to be used without configuration.

stuartwdouglas requested a review from Sanne September 7, 2021 05:50

quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Sep 7, 2021

stuartwdouglas mentioned this pull request Sep 7, 2021

Automatically configure connector name #19953

Closed

gsmet reviewed Sep 7, 2021

View reviewed changes

Sanne approved these changes Sep 7, 2021

View reviewed changes

stuartwdouglas force-pushed the auto-create-devservices branch from c4434d3 to 6aeb4bd Compare September 7, 2021 23:30

quarkus-bot bot added the area/panache label Sep 7, 2021

stuartwdouglas force-pushed the auto-create-devservices branch from 6aeb4bd to 3ecce72 Compare September 8, 2021 01:03

stuartwdouglas force-pushed the auto-create-devservices branch from 3ecce72 to b3b89ca Compare September 8, 2021 04:23

Default to drop-and-create for DevServices

19566de

This allows for hibernate to be used without configuration.

stuartwdouglas force-pushed the auto-create-devservices branch from b3b89ca to 19566de Compare September 8, 2021 07:04

stuartwdouglas merged commit 4621f42 into quarkusio:main Sep 8, 2021

quarkus-bot bot added this to the 2.3 - main milestone Sep 8, 2021

Default to drop-and-create for DevServices #19951

Default to drop-and-create for DevServices #19951

Conversation

stuartwdouglas commented Sep 7, 2021

stuartwdouglas commented Sep 7, 2021

gsmet left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 7, 2021 • edited Loading

Failing Jobs - Building f56f305

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/panache/hibernate-orm-panache/deployment

Sanne commented Sep 7, 2021

geoand commented Sep 7, 2021

Sanne commented Sep 7, 2021

quarkus-bot bot commented Sep 7, 2021 • edited Loading

Failing Jobs - Building c4434d3

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/panache/hibernate-orm-panache/deployment

quarkus-bot bot commented Sep 8, 2021 • edited Loading

Failing Jobs - Building 3ecce72

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/panache/hibernate-orm-panache/deployment

quarkus-bot bot commented Sep 8, 2021 • edited Loading

Failing Jobs - Building b3b89ca

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/panache/hibernate-orm-panache/deployment

quarkus-bot bot commented Sep 7, 2021 •

edited

Loading

Failing Jobs - Building `f56f305`

quarkus-bot bot commented Sep 7, 2021 •

edited

Loading

Failing Jobs - Building `c4434d3`

quarkus-bot bot commented Sep 8, 2021 •

edited

Loading

Failing Jobs - Building `3ecce72`

quarkus-bot bot commented Sep 8, 2021 •

edited

Loading

Failing Jobs - Building `b3b89ca`