Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailer-deployment to bom #19939

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Add mailer-deployment to bom #19939

merged 1 commit into from
Sep 6, 2021

Conversation

ggrebert
Copy link
Contributor

@ggrebert ggrebert commented Sep 6, 2021

The dependency quarkus-mail-deployment is not set in the bom.

Work around used by custom extension:

<dependency>
  <groupId>io.quarkus</groupId>
  <artifactId>quarkus-mailer-deployment</artifactId>
  <version>${quarkus.version}</version>
</dependency>

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 6, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Sep 6, 2021
@ggrebert ggrebert changed the title add mailer-deployment to bom Add mailer-deployment to bom Sep 6, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gsmet
Copy link
Member

gsmet commented Sep 6, 2021

@aloubyansky we don't have anything in place to catch this sort of thing?

@aloubyansky
Copy link
Member

I guess not. We should be doing this kind of check though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants