Include relevant upstream catalogs even if their versions aren't recommended for new projects #19908
Conversation
quarkus-bot
bot
added
area/cli
|
@gastaldi do you mind reviewing this one? Thanks! |
| * @deprecated in favor of {@link io.quarkus.registry.catalog.PlatformStreamCoords} | ||
| */ | ||
| @Deprecated | ||
| public class StreamCoords extends io.quarkus.registry.catalog.PlatformStreamCoords { |
There was a problem hiding this comment.
I think this can be removed completely? It's not being used anywhere AFAIK
There was a problem hiding this comment.
You are most probably right. I kept it, just in case, for backward compatibility.
There was a problem hiding this comment.
Right, my point is that deleting it shouldn´t break backward compatibility since it's already well encapsulated from the public APIs. It's unlikely that someone is using it since it was introduced less than 3 months ago 😉
There was a problem hiding this comment.
It shouldn't affect our dev tools, so yes, I think it's safe to remove it.
There was a problem hiding this comment.
@ia3andy just to confirm, this class is not used in code.quarkus.io, right?
There was a problem hiding this comment.
It doesn't look like it.
aloubyansky
force-pushed
the
upstream-platform-catalog
branch
from
9df8576 to
dd1081c
Compare
…mmended for new projects Moved io.quarkus.maven.StreamCoords to io.quarkus.registry.catalog.PlatformStreamCoords
aloubyansky
force-pushed
the
upstream-platform-catalog
branch
from
dd1081c to
9a15b82
Compare
gastaldi
added
the
triage/waiting-for-ci
|
The errors aren't related to the change. E.g. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
It may happen that downstream platform versions reference upstream Quarkus versions that are not recommended any more for new projects in the upstream community. This PR fixes a few issues making sure the dev tools still list the relevant upstream catalogs for downstream versions.
Also deprecated io.quarkus.maven.StreamCoords in favor of io.quarkus.registry.catalog.PlatformStreamCoords