More descriptive error messages for unsupported Jandex storage format versions #19876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe it would be possible to handle an unsupported version error similarly to "too old version" error and reindex on the fly, but it feels weird. So for now, I went with this conservative approach of just improving the error message. |
|
Isn't the error message already improved in jandex? I think it's fine to wait for 2.4.1 instead |
|
Right, Jandex has an improved error message now. But Jandex's |
mkouba
reviewed
Sep 2, 2021
core/deployment/src/main/java/io/quarkus/deployment/index/IndexingUtil.java
Show resolved
Hide resolved
mkouba
approved these changes
Sep 2, 2021
gastaldi
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.