-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc - transactional observers should register standard synchronization instead of interposed #19873
Conversation
61143fc
to
6eafef9
Compare
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/EventImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me all is fine. Just added a note under the existing comment.
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6eafef9
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/narayana-jta/deployment integration-tests/container-image/maven-invoker-way
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 97 more 📦 extensions/narayana-jta/deployment✖
✖
✖
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-db2✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mariadb✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mssql✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mysql✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-postgresql✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/narayana-jta/deployment
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 97 more 📦 extensions/narayana-jta/deployment✖
✖
✖
⚙️ JVM Tests - JDK 16 #- Failing: extensions/narayana-jta/deployment extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/container-image/maven-invoker-way
! Skipped: docs extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 100 more 📦 extensions/narayana-jta/deployment✖
✖
✖
📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-db2✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mariadb✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mssql✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mysql✖
📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-postgresql✖
⚙️ MicroProfile TCKs Tests #- Failing: tcks/microprofile-context-propagation
📦 tcks/microprofile-context-propagation✖
✖
✖
✖
✖
✖
✖
✖
⚙️ Native Tests - Cache #- Failing: integration-tests/cache integration-tests/infinispan-cache-jpa
📦 integration-tests/cache✖ 📦 integration-tests/infinispan-cache-jpa✖ ⚙️ Native Tests - Data1 #- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/hibernate-orm-tenancy/datasource integration-tests/jpa-derby and 4 more
📦 integration-tests/hibernate-orm-tenancy/connection-resolver✖ 📦 integration-tests/hibernate-orm-tenancy/datasource✖ 📦 integration-tests/jpa-derby✖ 📦 integration-tests/jpa-h2✖ 📦 integration-tests/jpa-mariadb✖ 📦 integration-tests/jpa-mssql✖ 📦 integration-tests/jpa-without-entity✖ ⚙️ Native Tests - Data2 #- Failing: integration-tests/jpa integration-tests/jpa-db2 integration-tests/jpa-mapping-xml/legacy-app and 3 more
📦 integration-tests/jpa✖ 📦 integration-tests/jpa-db2✖ 📦 integration-tests/jpa-mapping-xml/legacy-app✖ 📦 integration-tests/jpa-mapping-xml/modern-app✖ 📦 integration-tests/jpa-mysql✖ 📦 integration-tests/jpa-oracle✖ ⚙️ Native Tests - Data3 #- Failing: integration-tests/flyway integration-tests/hibernate-orm-envers integration-tests/hibernate-orm-panache and 3 more
📦 integration-tests/flyway✖ 📦 integration-tests/hibernate-orm-envers✖ 📦 integration-tests/hibernate-orm-panache✖ 📦 integration-tests/hibernate-orm-panache-kotlin✖
📦 integration-tests/liquibase✖ 📦 integration-tests/liquibase-mongodb✖ ⚙️ Native Tests - Data4 #- Failing: integration-tests/hibernate-orm-rest-data-panache integration-tests/mongodb-panache integration-tests/mongodb-panache-kotlin and 1 more
📦 integration-tests/hibernate-orm-rest-data-panache✖ 📦 integration-tests/mongodb-panache✖ 📦 integration-tests/mongodb-panache-kotlin✖
📦 integration-tests/mongodb-rest-data-panache✖ ⚙️ Native Tests - Data5 #- Failing: integration-tests/hibernate-orm-tenancy/schema integration-tests/jpa-postgresql integration-tests/jpa-postgresql-withxml and 1 more
📦 integration-tests/hibernate-orm-tenancy/schema✖ 📦 integration-tests/jpa-postgresql✖ 📦 integration-tests/jpa-postgresql-withxml✖ 📦 integration-tests/narayana-jta✖ ⚙️ Native Tests - Data6 #- Failing: integration-tests/hibernate-search-orm-elasticsearch integration-tests/hibernate-search-orm-elasticsearch-aws
📦 integration-tests/hibernate-search-orm-elasticsearch✖ 📦 integration-tests/hibernate-search-orm-elasticsearch-aws✖ ⚙️ Native Tests - Main #- Failing: integration-tests/main
📦 integration-tests/main✖ ⚙️ Native Tests - Misc1 #- Failing: integration-tests/quartz integration-tests/qute
📦 integration-tests/quartz✖ 📦 integration-tests/qute✖ ⚙️ Native Tests - Misc2 #- Failing: integration-tests/hibernate-validator
📦 integration-tests/hibernate-validator✖ ⚙️ Native Tests - Misc3 #- Failing: integration-tests/smallrye-opentracing
📦 integration-tests/smallrye-opentracing✖ ⚙️ Native Tests - Misc4 #- Failing: integration-tests/micrometer-prometheus
📦 integration-tests/micrometer-prometheus✖ ⚙️ Native Tests - Security1 #- Failing: integration-tests/elytron-security-jdbc
📦 integration-tests/elytron-security-jdbc✖ ⚙️ Native Tests - Security3 #- Failing: integration-tests/vault-agroal integration-tests/vault-app
📦 integration-tests/vault-agroal✖
✖
✖
📦 integration-tests/vault-app✖ ⚙️ Native Tests - Spring #- Failing: integration-tests/spring-data-jpa integration-tests/spring-data-rest
📦 integration-tests/spring-data-jpa✖ 📦 integration-tests/spring-data-rest✖ ⚙️ Native Tests - Windows - hibernate-validator #- Failing: integration-tests/hibernate-validator
📦 integration-tests/hibernate-validator✖ |
Some CI failures are probably related.. |
Yeah, I know. Apparently, JTA already has a CDI bean for |
…n instead of interposed.
@manovotn oh, sorry I haven't realized that we have provided the CDI bean for TM in JTA already... |
No worries, at least next time I'll know :-) |
Failing Jobs - Building ac40c15
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 16 #- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/mongodb-panache
📦 integration-tests/hibernate-orm-tenancy/connection-resolver✖
✖
✖
📦 integration-tests/mongodb-panache✖
⚙️ Native Tests - Data1 #- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver
📦 integration-tests/hibernate-orm-tenancy/connection-resolver✖
✖
✖
|
These failures no longer look relevant, they're coming from Hibernate multitenancy tests. @mkouba please review this PR when you have a moment to spare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak about the JTA part but the rest of the PR looks good! ;-)
hey, the Hibernate ORM / multitenancy integration tests started failing today. I suspect it's related?
Please see https://github.com/quarkusio/quarkus/pull/19928/checks?check_run_id=3524105980 |
Arc-side fix for #18737
Cc @ochaloup