Make KubernetesClientErrorHandler always throw a RuntimeException

[iocanel]

Resolves: #19870

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)
• title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

[geoand]

Are there any potential side effects to always throwing the exception?

[gastaldi]

That makes sense. I'm curious about @geoand's question too

[iocanel]

Are there any potential side effects to always throwing the exception?

Yes, the build breaks and the users get's the stack trace of the exception.
With the current behavior the error becomes an NPE (unless its an SSLSomethingException) without any indication of what might be wrong.

I feel that when a user requests an operation (in this case container image build) and this cannot be done for any reason, the build should immediately fail. If not random things might happen later on, that are hard for users to decipher.

[gsmet]

@geoand @iocanel should we backport this one for 2.2.2.Final?

[geoand]

That sounds like a good idea to me

…

On Mon, Sep 6, 2021, 12:07 Guillaume Smet ***@***.***> wrote: @geoand <https://github.com/geoand> @iocanel <https://github.com/iocanel> should we backport this one for 2.2.2.Final? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19871 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP3NJBJ3AGE7JJA36BDUASAERANCNFSM5DJDZLOQ> .