Add missing @ConfigItem annotations #19826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @machi1990 for the catch ;) I'll provide more tests when I create the guide |
machi1990
reviewed
Sep 1, 2021
...ibase-mongodb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbConfig.java
Outdated
Show resolved
Hide resolved
machi1990
reviewed
Sep 1, 2021
...godb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
loicmathieu
force-pushed
the
fix-liquibase-mongodb
branch
from
02009a2 to
cdd280a
Compare
|
@machi1990 thanks for the review, I updated my PR with defaultValue and more suitable init values |
Thanks for the followup @loicmathieu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.