Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Dev UI Tile even if there is no Guide #19779

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Show Dev UI Tile even if there is no Guide #19779

merged 1 commit into from
Aug 31, 2021

Conversation

phillip-kruger
Copy link
Member

Fix #19674

Signed-off-by:Phillip Kruger [email protected]

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@phillip-kruger phillip-kruger changed the title Show Dev UI Tile even if there is no Guide. Show Dev UI Tile even if there is no Guide Aug 30, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2021

Failing Jobs - Building 979d0c7

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: ../../smallrye-reactive-messaging-kafka/deployment 
! Skipped: ../../../docs ../../../integration-tests/kubernetes/quarkus-standard-way-kafka ../../../integration-tests/reactive-messaging-kafka and 1 more

📦 ../../smallrye-reactive-messaging-kafka/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-smallrye-reactive-messaging-kafka-deployment: There are test failures.

Please refer to /home/runner/work/quarkus/quarkus/extensions/smallrye-reactive-messaging-kafka/deployment/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@gsmet gsmet merged commit fadbcf3 into quarkusio:main Aug 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 31, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 31, 2021
@phillip-kruger phillip-kruger deleted the dev-ui-card-issue3 branch August 31, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev UI: Extension card not visible out-of-the-box
2 participants